Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2007113007: Offline Pages: Add NULL-checks for when the model is NULL (incognito mode) (Closed)

Created:
4 years, 7 months ago by dewittj
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Offline Pages: Add NULL-checks for when the model is NULL (incognito mode) Recently offline pages was changed to be completely disabled in incognito profiles, since it is no longer associated with bookmarks, so some consumers failed to check for null. BUG=613359 Review-Url: https://codereview.chromium.org/2004473002 Cr-Commit-Position: refs/heads/master@{#395422} (cherry picked from commit 261c816b0900eec6c3b41277288ccd4020c23f5d) Committed: https://chromium.googlesource.com/chromium/src/+/2f02d09e1696e7f4df14a0f73712f51397a8f5db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dewittj
4 years, 7 months ago (2016-05-25 16:02:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f02d09e1696e7f4df14a0f73712f51397a8f5db.

Powered by Google App Engine
This is Rietveld 408576698