[wasm] Delay throwing an error until the sequential phase of the compilation.

[wasm] Delay throwing an error until the sequential phase of the compilation.

Signalling an error to the ErrorThrower causes a heap allocation and should
therefore not happen in the parallel phase of the compilation.

Additionally I did some refactoring: I pulled the function
BuildGraphForWasmFunction into the WasmCompilationUnit and as a consequence
I can use the class fields directly instead of passing them as parameters.

BUG=chromium::614291
LOG=N
R=titzer@chromium.org, bradnelson@chromium.org

Committed: https://crrev.com/a51d0585e225966a36a58a45894fcb237215b2b1
Cr-Commit-Position: refs/heads/master@{#36515}

[bradnelson, 2016-05-25 10:50:12]

https://codereview.chromium.org/2007113004/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2007113004/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:3264: ScopedVector<char> buffer(128);
How do we know this is enough?

[bradnelson, 2016-05-25 11:18:56]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-05-25 11:18:57]

lgtm

https://codereview.chromium.org/2007113004/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2007113004/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:3264: ScopedVector<char> buffer(128);
On 2016/05/25 10:50:12, bradnelson wrote:
> How do we know this is enough?

Nevermind, this is fine.

[commit-bot: I haz the power, 2016-05-25 11:19:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007113004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007113004/1

[commit-bot: I haz the power, 2016-05-25 11:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 11:22:14]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15973)

[titzer, 2016-05-25 12:53:56]

On 2016/05/25 11:22:14, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15973)

lgtm

[ahaas, 2016-05-25 12:54:14]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-05-25 12:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007113004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007113004/1

[commit-bot: I haz the power, 2016-05-25 12:56:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 12:56:17]

Description was changed from

==========
[wasm] Delay throwing an error until the sequential phase of the compilation.

Signalling an error to the ErrorThrower causes a heap allocation and should
therefore not happen in the parallel phase of the compilation.

Additionally I did some refactoring: I pulled the function
BuildGraphForWasmFunction into the WasmCompilationUnit and as a consequence
I can use the class fields directly instead of passing them as parameters.

BUG=chromium::614291
LOG=N
R=titzer@chromium.org, bradnelson@chromium.org
==========

to

==========
[wasm] Delay throwing an error until the sequential phase of the compilation.

Signalling an error to the ErrorThrower causes a heap allocation and should
therefore not happen in the parallel phase of the compilation.

Additionally I did some refactoring: I pulled the function
BuildGraphForWasmFunction into the WasmCompilationUnit and as a consequence
I can use the class fields directly instead of passing them as parameters.

BUG=chromium::614291
LOG=N
R=titzer@chromium.org, bradnelson@chromium.org

Committed: https://crrev.com/a51d0585e225966a36a58a45894fcb237215b2b1
Cr-Commit-Position: refs/heads/master@{#36515}
==========

[commit-bot: I haz the power, 2016-05-25 12:56:18]

Patchset 1 (id:??) landed as
https://crrev.com/a51d0585e225966a36a58a45894fcb237215b2b1
Cr-Commit-Position: refs/heads/master@{#36515}