third_party/WebKit/Source/core/layout/LayoutListMarker.cpp - Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo for length access. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.h ('k') | third_party/WebKit/Source/core/layout/LayoutText.cpp » ('j') | third_party/WebKit/Source/wtf/text/StringBuilder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

index 31e5f27a948e60f885ee9b889de0a50a7b97edce..ee3042ebc3f725ffeddc1b461b461c50c0b15fdb 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

@@ -204,7 +204,7 @@ LayoutUnit LayoutListMarker::getWidthOfTextWithSuffix() const

if (m_text.isEmpty())

return LayoutUnit();

const Font& font = style()->font();

- LayoutUnit itemWidth = LayoutUnit(font.width(m_text));

+ LayoutUnit itemWidth = LayoutUnit(font.width(TextRun(m_text)));

// TODO(wkorman): Look into constructing a text run for both text and suffix

// and painting them together.

UChar suffix[2] = { ListMarkerText::suffix(style()->listStyleType(), m_listItem->value()), ' ' };