third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp - Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove bad assert. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h ('k') | third_party/WebKit/Source/platform/text/TextRun.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

index 13ae63b0bd9b8cd44e4fbb9f7322ddd87980ede7..a4f4b997fd5e27be932abc49ec012d045112143f 100644

--- a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

@@ -139,7 +139,9 @@ void MHTMLArchive::generateMHTMLPart(

ASSERT(contentID.isEmpty() || contentID[0] == '<');

StringBuilder stringBuilder;

- stringBuilder.append("--" + boundary + "\r\n");

+ stringBuilder.append("--");

+ stringBuilder.append(boundary);

+ stringBuilder.append("\r\n");

stringBuilder.appendLiteral("Content-Type: ");

stringBuilder.append(resource.mimeType);

@@ -165,7 +167,7 @@ void MHTMLArchive::generateMHTMLPart(

if (!resource.url.protocolIsAbout()) {

stringBuilder.appendLiteral("Content-Location: ");

- stringBuilder.append(resource.url);

+ stringBuilder.append(resource.url.getString());

stringBuilder.appendLiteral("\r\n");

}