Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2007093002: CMake: skia_link_arguments.txt repects BUILD_SHARED_LIBS (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMake: skia_link_arguments.txt repects BUILD_SHARED_LIBS . GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2007093002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/5d04fda87747d82f4039cecf3e72b62ddf1ca76d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M cmake/CMakeLists.txt View 1 chunk +15 lines, -3 lines 0 comments Download
M cmake/README.md View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007093002/1
4 years, 7 months ago (2016-05-24 17:04:18 UTC) #3
hal.canary
PTAL seems to work correctly locally for me.
4 years, 7 months ago (2016-05-24 17:04:35 UTC) #5
jcgregorio
lgtm
4 years, 7 months ago (2016-05-24 17:06:29 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 17:22:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007093002/1
4 years, 7 months ago (2016-05-24 18:22:28 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 18:23:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5d04fda87747d82f4039cecf3e72b62ddf1ca76d

Powered by Google App Engine
This is Rietveld 408576698