Move CSSPropertyID templates instantiations to a separate file.

Move CSSPropertyID templates instantiations to a separate file.

core/CSSPropertyNames.h is needed a lot of places, but the template part there
was only required at a few places.

BUG=614015
Committed: https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96
Cr-Commit-Position: refs/heads/master@{#395941}

[mstensho (USE GERRIT), 2016-05-24 22:22:23]

mstensho@opera.com changed reviewers:
+ rune@opera.com

[rune, 2016-05-25 07:32:11]

lgtm

[Timothy Loh, 2016-05-25 07:37:36]

Does this mean that using HashSet<CSSPropertyID> or HashMap<CSSPropertyID, X>
needs this file to be included to function correctly, but might not actually
error if you don't include it? If so it seems too error prone.

[mstensho (USE GERRIT), 2016-05-25 08:02:10]

On 2016/05/25 07:37:36, Timothy Loh wrote:
> Does this mean that using HashSet<CSSPropertyID> or HashMap<CSSPropertyID, X>
> needs this file to be included to function correctly, but might not actually
> error if you don't include it? If so it seems too error prone.

All I can say is that if I don't include it, it doesn't compile. Do you still
feel this is too risky?

[Timothy Loh, 2016-05-25 08:15:20]

On 2016/05/25 08:02:10, mstensho wrote:
> On 2016/05/25 07:37:36, Timothy Loh wrote:
> > Does this mean that using HashSet<CSSPropertyID> or HashMap<CSSPropertyID,
X>
> > needs this file to be included to function correctly, but might not actually
> > error if you don't include it? If so it seems too error prone.
> 
> All I can say is that if I don't include it, it doesn't compile. Do you still
> feel this is too risky?

I guess it's fine if it makes a compile error. Shouldn't we also remove the
HashTraits/HashFunctions includes though?

[mstensho (USE GERRIT), 2016-05-25 09:29:57]

On 2016/05/25 08:15:20, Timothy Loh wrote:
> On 2016/05/25 08:02:10, mstensho wrote:
> > On 2016/05/25 07:37:36, Timothy Loh wrote:
> > > Does this mean that using HashSet<CSSPropertyID> or HashMap<CSSPropertyID,
> X>
> > > needs this file to be included to function correctly, but might not
actually
> > > error if you don't include it? If so it seems too error prone.
> > 
> > All I can say is that if I don't include it, it doesn't compile. Do you
still
> > feel this is too risky?
> 
> I guess it's fine if it makes a compile error. Shouldn't we also remove the
> HashTraits/HashFunctions includes though?

Good idea. Did that. Also removed core/css/parser/CSSParserMode.h and string.h

[mstensho (USE GERRIT), 2016-05-25 11:30:30]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-05-25 11:30:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/2007073003/#ps20001
(title: "Remove more includes from CSSPropertyNames.h")

[commit-bot: I haz the power, 2016-05-25 11:30:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007073003/20001

[commit-bot: I haz the power, 2016-05-25 16:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 16:35:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mstensho (USE GERRIT), 2016-05-25 16:53:43]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-05-25 16:54:05]

pink is the new green

[commit-bot: I haz the power, 2016-05-25 16:54:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007073003/20001

[commit-bot: I haz the power, 2016-05-25 18:37:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 18:39:48]

Description was changed from

==========
Move CSSPropertyID templates instantiations to a separate file.

core/CSSPropertyNames.h is needed a lot of places, but the template part there
was only required at a few places.

BUG=614015
==========

to

==========
Move CSSPropertyID templates instantiations to a separate file.

core/CSSPropertyNames.h is needed a lot of places, but the template part there
was only required at a few places.

BUG=614015

Committed: https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96
Cr-Commit-Position: refs/heads/master@{#395941}
==========

[commit-bot: I haz the power, 2016-05-25 18:39:49]

Patchset 2 (id:??) landed as
https://crrev.com/2373d35f875ed1b64e9d6cbeff0160e5d823ce96
Cr-Commit-Position: refs/heads/master@{#395941}