Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2007033002: Remove extra DNG images and use smaller HTC.dng (Closed)

Created:
4 years, 7 months ago by scroggo_chromium
Modified:
4 years, 7 months ago
Reviewers:
msarett, scroggo, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove extra DNG images and use smaller HTC.dng Update SK_IMAGE_VERSION to 7. This removes the following files from dm testing: lg_g4_iso_800.dng Fuji_X20.dng These DNG images are very large, and cause us to use a lot of memory in testing. Moreover, they do not test anything that is not covered by HTC.dng In addition, use the smaller version of HTC.dng (which is already in use in dm) in nanobench. BUG=skia:5307 BUG=skia:5283 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2007033002 Committed: https://skia.googlesource.com/skia/+/5221fef17bb76163eedd101799b6155278cbe2b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M SK_IMAGE_VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
scroggo
4 years, 7 months ago (2016-05-24 12:38:10 UTC) #3
borenet
LGTM
4 years, 7 months ago (2016-05-24 12:40:15 UTC) #4
msarett
lgtm
4 years, 7 months ago (2016-05-24 12:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007033002/1
4 years, 7 months ago (2016-05-24 13:08:37 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 13:23:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5221fef17bb76163eedd101799b6155278cbe2b9

Powered by Google App Engine
This is Rietveld 408576698