src/interpreter/bytecodes.h - Issue 2007023003: [interpreter] Address naming inconsistencies in bytecodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecodes.h

Issue 2007023003: [interpreter] Address naming inconsistencies in bytecodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0056-register-only

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecodes.h

diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h

index 1d462620ae599b594cc7f7236144959a4d8e41eb..27383e7d1e83e7cd24dc31b15b18b39c8adebb7a 100644

--- a/src/interpreter/bytecodes.h

+++ b/src/interpreter/bytecodes.h

@@ -126,23 +126,23 @@ namespace interpreter {

V(Mov, AccumulatorUse::kNone, OperandType::kReg, OperandType::kRegOut) \

/* LoadIC operations */ \

rmcilroy 2016/05/24 15:23:49 nit - update this comment.

oth 2016/05/25 08:10:28 Done.

- V(LoadIC, AccumulatorUse::kWrite, OperandType::kReg, OperandType::kIdx, \

- OperandType::kIdx) \

+ V(LdaNamedProperty, AccumulatorUse::kWrite, OperandType::kReg, \

+ OperandType::kIdx, OperandType::kIdx) \

V(LdrNamedProperty, AccumulatorUse::kNone, OperandType::kReg, \

OperandType::kIdx, OperandType::kIdx, OperandType::kRegOut) \

- V(KeyedLoadIC, AccumulatorUse::kReadWrite, OperandType::kReg, \

+ V(LdaKeyedProperty, AccumulatorUse::kReadWrite, OperandType::kReg, \

OperandType::kIdx) \

V(LdrKeyedProperty, AccumulatorUse::kRead, OperandType::kReg, \

OperandType::kIdx, OperandType::kRegOut) \

/* StoreIC operations */ \

rmcilroy 2016/05/24 15:23:49 ditto

oth 2016/05/25 08:10:28 Done.

- V(StoreICSloppy, AccumulatorUse::kRead, OperandType::kReg, \

+ V(StaNamedPropertySloppy, AccumulatorUse::kRead, OperandType::kReg, \

OperandType::kIdx, OperandType::kIdx) \

- V(StoreICStrict, AccumulatorUse::kRead, OperandType::kReg, \

+ V(StaNamedPropertyStrict, AccumulatorUse::kRead, OperandType::kReg, \

OperandType::kIdx, OperandType::kIdx) \

- V(KeyedStoreICSloppy, AccumulatorUse::kRead, OperandType::kReg, \

+ V(StaKeyedPropertySloppy, AccumulatorUse::kRead, OperandType::kReg, \

OperandType::kReg, OperandType::kIdx) \

- V(KeyedStoreICStrict, AccumulatorUse::kRead, OperandType::kReg, \

+ V(StaKeyedPropertyStrict, AccumulatorUse::kRead, OperandType::kReg, \

OperandType::kReg, OperandType::kIdx) \

/* Binary Operators */ \

« no previous file with comments | « src/interpreter/bytecode-peephole-optimizer.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »