test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc - Issue 2007023003: [interpreter] Address naming inconsistencies in bytecodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

Issue 2007023003: [interpreter] Address naming inconsistencies in bytecodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0056-register-only

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/interpreter/bytecode-array-iterator-unittest.cc ('k') | test/unittests/interpreter/bytecode-pipeline-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc b/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

index e9bf9be23e77352cdf8c132a1d2deae6675698ef..a5a4322ddb8018593011c947aa1425fa318ea575 100644

--- a/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

+++ b/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

@@ -388,8 +388,8 @@ TEST_F(BytecodePeepholeOptimizerTest, MergeLoadICStar) {

static_cast<uint32_t>(Register(256).ToOperand())};

const int expected_operand_count = static_cast<int>(arraysize(operands));

- BytecodeNode first(Bytecode::kLoadIC, operands[0], operands[1], operands[2],

- OperandScale::kSingle);

+ BytecodeNode first(Bytecode::kLdaNamedProperty, operands[0], operands[1],

+ operands[2], OperandScale::kSingle);

BytecodeNode second(Bytecode::kStar, operands[3], OperandScale::kDouble);

BytecodeNode third(Bytecode::kReturn);

optimizer()->Write(&first);

@@ -410,13 +410,13 @@ TEST_F(BytecodePeepholeOptimizerTest, MergeLoadICStar) {

CHECK_EQ(last_written().bytecode(), third.bytecode());

}

-TEST_F(BytecodePeepholeOptimizerTest, MergeKeyedLoadICStar) {

+TEST_F(BytecodePeepholeOptimizerTest, MergeLdaKeyedPropertyStar) {

const uint32_t operands[] = {static_cast<uint32_t>(Register(31).ToOperand()),

9999997,

static_cast<uint32_t>(Register(1).ToOperand())};

const int expected_operand_count = static_cast<int>(arraysize(operands));

- BytecodeNode first(Bytecode::kKeyedLoadIC, operands[0], operands[1],

+ BytecodeNode first(Bytecode::kLdaKeyedProperty, operands[0], operands[1],

OperandScale::kQuadruple);

BytecodeNode second(Bytecode::kStar, operands[2], OperandScale::kSingle);

BytecodeNode third(Bytecode::kReturn);