src/interpreter/bytecode-array-builder.h - Issue 2007023003: [interpreter] Address naming inconsistencies in bytecodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 2007023003: [interpreter] Address naming inconsistencies in bytecodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0056-register-only

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-array-builder.h

diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h

index 68a2f3bc62488f0b8b5c6da628781763e5065dcc..44e37f43a98073dd9a7061de8e024f43d6251e5b 100644

--- a/src/interpreter/bytecode-array-builder.h

+++ b/src/interpreter/bytecode-array-builder.h

@@ -288,8 +288,8 @@ class BytecodeArrayBuilder final : public ZoneObject {

static Bytecode BytecodeForBinaryOperation(Token::Value op);

static Bytecode BytecodeForCountOperation(Token::Value op);

static Bytecode BytecodeForCompareOperation(Token::Value op);

- static Bytecode BytecodeForStoreIC(LanguageMode language_mode);

- static Bytecode BytecodeForKeyedStoreIC(LanguageMode language_mode);

+ static Bytecode BytecodeForStoreNamedProperty(LanguageMode language_mode);

+ static Bytecode BytecodeForStoreKeyedProperty(LanguageMode language_mode);

static Bytecode BytecodeForLoadGlobal(TypeofMode typeof_mode);

static Bytecode BytecodeForStoreGlobal(LanguageMode language_mode);

static Bytecode BytecodeForStoreLookupSlot(LanguageMode language_mode);

« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | src/interpreter/bytecode-array-builder.cc » ('j') | no next file with comments »