Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007023003: [interpreter] Address naming inconsistencies in bytecodes. (Closed)

Created:
4 years, 7 months ago by oth
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@oth-0056-register-only
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Address naming inconsistencies in bytecodes. BUG=v8:4280 LOG=N Committed: https://crrev.com/31c77b13df97533522493a61f8205bba016fda78 Cr-Commit-Position: refs/heads/master@{#36509}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : A couple more. #

Patch Set 4 : Rebase. #

Total comments: 4

Patch Set 5 : ... #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1137 lines, -1135 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 5 chunks +14 lines, -12 lines 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 3 4 1 chunk +9 lines, -9 lines 0 comments Download
M src/interpreter/interpreter.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CountOperators.golden View 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CreateArguments.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CreateRestParameter.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden View 1 chunk +128 lines, -128 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyCall.golden View 1 chunk +128 lines, -128 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyStores.golden View 11 chunks +524 lines, -524 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden View 2 chunks +256 lines, -256 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TopLevelObjectLiterals.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/interpreter/bytecode-pipeline-unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
oth
Ross: PTAL, here are the naming changes that we took out of the bytecode fusion ...
4 years, 7 months ago (2016-05-24 14:54:29 UTC) #2
rmcilroy
Thanks for the change, LGTM
4 years, 7 months ago (2016-05-24 15:22:13 UTC) #3
rmcilroy
Two comments I missed. Still LGTM https://codereview.chromium.org/2007023003/diff/60001/src/interpreter/bytecodes.h File src/interpreter/bytecodes.h (right): https://codereview.chromium.org/2007023003/diff/60001/src/interpreter/bytecodes.h#newcode128 src/interpreter/bytecodes.h:128: /* LoadIC operations ...
4 years, 7 months ago (2016-05-24 15:23:49 UTC) #4
Benedikt Meurer
LGTM on compiler
4 years, 7 months ago (2016-05-24 17:29:50 UTC) #5
oth
Thanks both. Comments incorporated. https://codereview.chromium.org/2007023003/diff/60001/src/interpreter/bytecodes.h File src/interpreter/bytecodes.h (right): https://codereview.chromium.org/2007023003/diff/60001/src/interpreter/bytecodes.h#newcode128 src/interpreter/bytecodes.h:128: /* LoadIC operations */ \ ...
4 years, 7 months ago (2016-05-25 08:10:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007023003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007023003/100001
4 years, 7 months ago (2016-05-25 10:12:58 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-25 10:45:25 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 10:47:37 UTC) #12
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/31c77b13df97533522493a61f8205bba016fda78
Cr-Commit-Position: refs/heads/master@{#36509}

Powered by Google App Engine
This is Rietveld 408576698