Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: ash/shelf/shelf_delegate.h

Issue 2007003002: mash: Preliminary support for shelf auto-hide (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shutdown
Patch Set: typo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_delegate.h
diff --git a/ash/shelf/shelf_delegate.h b/ash/shelf/shelf_delegate.h
index 16e041c4e454904b0b68dcd2282c408ac5513c33..17d861e8a38cd4be039c9a5669f693a1276e0f88 100644
--- a/ash/shelf/shelf_delegate.h
+++ b/ash/shelf/shelf_delegate.h
@@ -31,6 +31,12 @@ class ASH_EXPORT ShelfDelegate {
// Called when |shelf|'s auto-hide behavior changes.
virtual void OnShelfAutoHideBehaviorChanged(Shelf* shelf) = 0;
+ // Called after |shelf|'s auto-hide state changes.
msw 2016/05/25 01:10:33 nit: s/after/when/ to be consistent. 'On*changed'
James Cook 2016/05/25 16:24:26 Done, although frankly I would prefer all the comm
+ virtual void OnShelfAutoHideStateChanged(Shelf* shelf) = 0;
+
+ // Called when |shelf|'s visibility state is committed.
+ virtual void OnShelfVisibilityStateChanged(Shelf* shelf) = 0;
+
// Get the shelf ID from an application ID.
virtual ShelfID GetShelfIDForAppID(const std::string& app_id) = 0;

Powered by Google App Engine
This is Rietveld 408576698