chrome/browser/resources/local_discovery/local_discovery.html - Issue 20070002: Demo UI for device discovery and registration

Side by Side Diff: chrome/browser/resources/local_discovery/local_discovery.html

Issue 20070002: Demo UI for device discovery and registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Gate devices page on enable_mdns=1 Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/local_discovery/local_discovery.css ('K') | « chrome/browser/resources/local_discovery/local_discovery.css ('k') | chrome/browser/resources/local_discovery/local_discovery.js » ('j') | chrome/browser/resources/local_discovery/local_discovery.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Local Discovery Debug Page</title>	5 <title>Local Discovery Debug Page</title>

6 <link rel="stylesheet" href="local_discovery.css">	6 <link rel="stylesheet" href="local_discovery.css">

7 <script src="chrome://resources/js/cr.js"></script>	7 <script src="chrome://resources/js/cr.js"></script>

8 <script src="chrome://resources/js/util.js"></script>	8 <script src="chrome://resources/js/util.js"></script>

9 <script src="local_discovery.js"></script>	9 <script src="local_discovery.js"></script>

10 </head>	10 </head>

11 <body>	11 <body>

12 <p>	12 <p>

13 Searching for discoverable devices...	13 Searching for discoverable devices...

14 </p>	14 </p>

15 <div>	15 <div>

	16 <div id="infoConsole"> </div>
	James Hawkins 2013/07/29 16:27:03 nit: IDs should be dash-case. nit: IDs should be dash-case. James Hawkins 2013/07/29 16:27:03 nit: Remove space in div. nit: Remove space in div. Noam Samuel 2013/08/02 22:20:02 Done. Show quoted text On 2013/07/29 16:27:03, James Hawkins wrote: > nit: IDs should be dash-case. Done.
16 <table id="devices-table" width="100%">	17 <table id="devices-table" width="100%">

17 <thead>	18 <thead>

18 <th>Name</th>	19 <th>Name</th>
	James Hawkins 2013/07/29 16:27:03 These strings need to be localized. These strings need to be localized. Noam Samuel 2013/07/29 16:58:01 This is a provisional UI behind a flag. We plan to Show quoted text On 2013/07/29 16:27:03, James Hawkins wrote: > These strings need to be localized. This is a provisional UI behind a flag. We plan to localize once we get UX signoff. James Hawkins 2013/07/29 17:01:57 Let's assume you're going to get signoff (otherwis Show quoted text On 2013/07/29 16:58:01, Noam Samuel wrote: > On 2013/07/29 16:27:03, James Hawkins wrote: > > These strings need to be localized. > > This is a provisional UI behind a flag. We plan to localize once we get UX > signoff. Let's assume you're going to get signoff (otherwise why bother doing any of this?) and add the proper localization. Noam Samuel 2013/08/02 22:20:02 Done. Show quoted text On 2013/07/29 17:01:57, James Hawkins wrote: > On 2013/07/29 16:58:01, Noam Samuel wrote: > > On 2013/07/29 16:27:03, James Hawkins wrote: > > > These strings need to be localized. > > > > This is a provisional UI behind a flag. We plan to localize once we get UX > > signoff. > > Let's assume you're going to get signoff (otherwise why bother doing any of > this?) and add the proper localization. Done.
19 <th>Domain</th>	20 <th>Domain</th>

20 <th>Port</th>	21 <th>Port</th>

21 <th>IP</th>	22 <th>IP</th>

22 <th>Metadata</th>	23 <th>Metadata</th>

23 <th>Last seen</th>	24 <th>Last seen</th>

24 <th>Registered</th>	25 <th>Register</th>

25 </thead>	26 </thead>

26 </table>	27 </table>

27 </div>	28 </div>

28 </body>	29 </body>

29 </html>	30 </html>

OLD	NEW