Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2006983002:
Flip linux_chromium_browser_side_navigation_rel to GN. (Closed)
|
Created:
4 years, 7 months ago by Dirk Pranke Modified:
4 years, 7 months ago Reviewers:
carlosk CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_linux_arm Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip linux_chromium_browser_side_navigation_rel to GN.
R=carlosk@chromium.org
BUG=605732
Committed: https://crrev.com/19eaeb5307be9770b35d34a741a682a7d7856295
Cr-Commit-Position: refs/heads/master@{#395781}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 16 (8 generated)
dpranke@chromium.org changed reviewers: + carlosk@chromium.org
I'm assuming this bot is still needed? If not, let me know and we can turn it off instead. Assuming it is, we're long past due to flip this over to GN.
Description was changed from ========== Flip linux_chromium_browser_side_navigation_rel to Linux. R= BUG=605732 ========== to ========== Flip linux_chromium_browser_side_navigation_rel to GN. R= BUG=605732 ==========
(flip to GN, not flip to Linux as the subject said :().
Description was changed from ========== Flip linux_chromium_browser_side_navigation_rel to GN. R= BUG=605732 ========== to ========== Flip linux_chromium_browser_side_navigation_rel to GN. R=carlosk@chromium.org BUG=605732 ==========
On 2016/05/24 02:06:27, Dirk Pranke wrote: > I'm assuming this bot is still needed? If not, let me know and we can turn it > off instead. > > Assuming it is, we're long past due to flip this over to GN. It is still needed indeed. RB LGTM as I'm not familiar with what's needed for the switch. Thanks!
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006983002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006983002/20001
Message was sent while issue was closed.
Description was changed from ========== Flip linux_chromium_browser_side_navigation_rel to GN. R=carlosk@chromium.org BUG=605732 ========== to ========== Flip linux_chromium_browser_side_navigation_rel to GN. R=carlosk@chromium.org BUG=605732 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Flip linux_chromium_browser_side_navigation_rel to GN. R=carlosk@chromium.org BUG=605732 ========== to ========== Flip linux_chromium_browser_side_navigation_rel to GN. R=carlosk@chromium.org BUG=605732 Committed: https://crrev.com/19eaeb5307be9770b35d34a741a682a7d7856295 Cr-Commit-Position: refs/heads/master@{#395781} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/19eaeb5307be9770b35d34a741a682a7d7856295 Cr-Commit-Position: refs/heads/master@{#395781} |
