Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 2006973004: Revert of cc: Cleanup tile manager a bit. (Closed)

Created:
4 years, 7 months ago by Irfan
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Cleanup tile manager a bit. (patchset #2 id:20001 of https://codereview.chromium.org/1998393002/ ) Reason for revert: Failed drmemory tests. see https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%281%29 Original issue's description: > cc: Cleanup tile manager a bit. > > - Removed typedefs/aliases that only complicate things > - Moved AssignGpuMemoryToTiles to private > - Removed AssignGpuMemoryToTiles args. > - Made TileManager ctor public and removed TileManager::Create > > R=enne, ericrk > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 > Cr-Commit-Position: refs/heads/master@{#395456} TBR=enne@chromium.org,ericrk@chromium.org,vmpstr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9ae4cf2fe86ee5cecfe020f30a27e2b4168580d9 Cr-Commit-Position: refs/heads/master@{#395680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -32 lines) Patch
M cc/tiles/tile_manager.h View 6 chunks +25 lines, -9 lines 0 comments Download
M cc/tiles/tile_manager.cc View 9 chunks +35 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Irfan
Created Revert of cc: Cleanup tile manager a bit.
4 years, 7 months ago (2016-05-24 19:15:43 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006973004/1
4 years, 7 months ago (2016-05-24 19:17:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 19:17:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006973004/1
4 years, 7 months ago (2016-05-24 19:55:30 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-24 19:55:32 UTC) #11
vmpstr
On 2016/05/24 19:55:32, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 7 months ago (2016-05-24 19:57:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006973004/1
4 years, 7 months ago (2016-05-24 19:58:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 19:59:36 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:02:16 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ae4cf2fe86ee5cecfe020f30a27e2b4168580d9
Cr-Commit-Position: refs/heads/master@{#395680}

Powered by Google App Engine
This is Rietveld 408576698