Background tracing: Enable field-trial control on Android

Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the 'navigation tracing' flag. Field-trials should be able to enable this too, just like on desktop.

R=simonhatch@chromium.org
BUG=614221
Committed: https://crrev.com/de6783b9149459e36a42a67b478aaa35804548e3
Cr-Commit-Position: refs/heads/master@{#395932}

[oystein (OOO til 10th of July), 2016-05-24 00:29:09]

ptal!

[oystein (OOO til 10th of July), 2016-05-24 00:29:25]

Description was changed from

==========
Background tracing: Enable field-trial control on Android

R=simonhatch@chromium.org
BUG=614221
==========

to

==========
Background tracing: Enable field-trial control on Android

R=simonhatch@chromium.org
BUG=614221
==========

[shatch, 2016-05-25 16:28:13]

chrome/browser/tracing lgtm

[oystein (OOO til 10th of July), 2016-05-25 16:29:09]

Description was changed from

==========
Background tracing: Enable field-trial control on Android

R=simonhatch@chromium.org
BUG=614221
==========

to

==========
Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the
'navigation tracing' flag. Finch should be enabled too, just like on desktop.

R=simonhatch@chromium.org
BUG=614221
==========

[oystein (OOO til 10th of July), 2016-05-25 16:33:00]

oysteine@chromium.org changed reviewers:
+ asvitkine@chromium.org, gab@chromium.org

[oystein (OOO til 10th of July), 2016-05-25 16:33:32]

On 2016/05/25 16:28:13, shatch wrote:
> chrome/browser/tracing lgtm

Thanks!

+asvitkine for chrome/browser/chrome_browser_field_trials*
+gab for chrome/browser/prefs/browser_prefs.cc

[gab, 2016-05-25 16:35:24]

c/b/prefs rubberstamp lgtm

[Alexei Svitkine (slow), 2016-05-25 16:43:51]

lgtm

please change CL description to not mention Finch, which is an internal codename

[oystein (OOO til 10th of July), 2016-05-25 16:44:37]

Description was changed from

==========
Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the
'navigation tracing' flag. Finch should be enabled too, just like on desktop.

R=simonhatch@chromium.org
BUG=614221
==========

to

==========
Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the
'navigation tracing' flag. Field-trials should be able to enable this too, just
like on desktop.

R=simonhatch@chromium.org
BUG=614221
==========

[oystein (OOO til 10th of July), 2016-05-25 16:45:27]

On 2016/05/25 16:43:51, Alexei Svitkine (slow) wrote:
> lgtm
> 
> please change CL description to not mention Finch, which is an internal
codename

Done, thanks.

[oystein (OOO til 10th of July), 2016-05-25 16:56:01]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2016-05-25 16:56:02]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
simonhatch@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2006973002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-25 16:56:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006973002/20001

[oystein (OOO til 10th of July), 2016-05-25 16:56:37]

The CQ bit was unchecked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2016-05-25 16:56:43]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2016-05-25 16:57:08]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-05-25 16:57:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006973002/20001

[oystein (OOO til 10th of July), 2016-05-25 16:58:29]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2016-05-25 16:58:29]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
simonhatch@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2006973002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-25 16:58:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006973002/40001

[commit-bot: I haz the power, 2016-05-25 18:08:53]

Description was changed from

==========
Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the
'navigation tracing' flag. Field-trials should be able to enable this too, just
like on desktop.

R=simonhatch@chromium.org
BUG=614221
==========

to

==========
Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the
'navigation tracing' flag. Field-trials should be able to enable this too, just
like on desktop.

R=simonhatch@chromium.org
BUG=614221
==========

[commit-bot: I haz the power, 2016-05-25 18:08:55]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-25 18:10:39]

Description was changed from

==========
Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the
'navigation tracing' flag. Field-trials should be able to enable this too, just
like on desktop.

R=simonhatch@chromium.org
BUG=614221
==========

to

==========
Background tracing: Enable field-trial control on Android

Currently the only way to enable background tracing on Android is via the
'navigation tracing' flag. Field-trials should be able to enable this too, just
like on desktop.

R=simonhatch@chromium.org
BUG=614221

Committed: https://crrev.com/de6783b9149459e36a42a67b478aaa35804548e3
Cr-Commit-Position: refs/heads/master@{#395932}
==========

[commit-bot: I haz the power, 2016-05-25 18:10:40]

Patchset 2 (id:??) landed as
https://crrev.com/de6783b9149459e36a42a67b478aaa35804548e3
Cr-Commit-Position: refs/heads/master@{#395932}