Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2006963002: Reland of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
tkent, caseq, Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (patchset #1 id:1 of https://codereview.chromium.org/2008753002/ ) Reason for revert: Creating reland patch (fixing error) Original issue's description: > Revert of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (patchset #4 id:60001 of https://codereview.chromium.org/2002513002/ ) > > Reason for revert: > This broke presubmit on layout tests with: > NameError: global name 'expected_files' is not defined > > Original issue's description: > > Don't check for all-pass baseline files in platform and virtual. > > > > BUG=613387 > > > > Committed: https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8 > > Cr-Commit-Position: refs/heads/master@{#395370} > > TBR=dpranke@chromium.org,tkent@chromium.org,qyearsley@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=613387 > > Committed: https://crrev.com/b8039077e177e3a636caf28492e9f30c13d97060 > Cr-Commit-Position: refs/heads/master@{#395438} TBR=dpranke@chromium.org,tkent@chromium.org,caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613387 Committed: https://crrev.com/98b84f707fd8961d40e9015cae79370975f1ac69 Cr-Commit-Position: refs/heads/master@{#395473}

Patch Set 1 #

Patch Set 2 : Fix mistake: rename last occurence of renamed variable #

Patch Set 3 : Include all original changes + new fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/PRESUBMIT.py View 1 2 2 chunks +29 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
qyearsley
Created Reland of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and ...
4 years, 7 months ago (2016-05-23 23:02:05 UTC) #1
qyearsley
On 2016/05/23 at 23:02:05, qyearsley wrote: > Created Reland of In LayoutTests PRESUBMIT, Don't check ...
4 years, 7 months ago (2016-05-23 23:08:43 UTC) #2
qyearsley
On 2016/05/23 at 23:08:43, qyearsley wrote: > On 2016/05/23 at 23:02:05, qyearsley wrote: > > ...
4 years, 7 months ago (2016-05-23 23:11:59 UTC) #3
tkent
lgtm
4 years, 7 months ago (2016-05-23 23:59:32 UTC) #4
caseq
lgtm
4 years, 7 months ago (2016-05-24 00:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006963002/60001
4 years, 7 months ago (2016-05-24 00:04:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-24 00:05:20 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 00:08:09 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98b84f707fd8961d40e9015cae79370975f1ac69
Cr-Commit-Position: refs/heads/master@{#395473}

Powered by Google App Engine
This is Rietveld 408576698