base/trace_event/memory_dump_manager.cc - Issue 2006943003: [tracing] Sanitize process memory dumps for background mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 2006943003: [tracing] Sanitize process memory dumps for background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@whitelist_mdp

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_allocator_dump.cc ('K') | « base/trace_event/memory_allocator_dump_unittest.cc ('k') | base/trace_event/process_memory_dump.h » ('j') | base/trace_event/process_memory_dump.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/memory_dump_manager.cc

diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc

index a698ea4cba77f49b4f1cc9e92fabfd621860937a..f286f9b9afb5e05b6a1297d48540d3389dd758eb 100644

--- a/base/trace_event/memory_dump_manager.cc

+++ b/base/trace_event/memory_dump_manager.cc

@@ -779,7 +779,7 @@ ProcessMemoryDump* MemoryDumpManager::ProcessMemoryDumpAsyncState::

auto iter = process_dumps.find(pid);

if (iter == process_dumps.end()) {

std::unique_ptr<ProcessMemoryDump> new_pmd(

- new ProcessMemoryDump(session_state));

+ new ProcessMemoryDump(session_state, req_args.level_of_detail));

iter = process_dumps.insert(std::make_pair(pid, std::move(new_pmd))).first;

}

return iter->second.get();