content/common/discardable_shared_memory_heap_unittest.cc - Issue 2006943003: [tracing] Sanitize process memory dumps for background mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/discardable_shared_memory_heap_unittest.cc

Issue 2006943003: [tracing] Sanitize process memory dumps for background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@whitelist_mdp

Patch Set: Fix stripping. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/tracing/common/process_metrics_memory_dump_provider_unittest.cc ('k') | gin/v8_isolate_memory_dump_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/discardable_shared_memory_heap_unittest.cc

diff --git a/content/common/discardable_shared_memory_heap_unittest.cc b/content/common/discardable_shared_memory_heap_unittest.cc

index 6e4aac4197f1f229d1bd5cbb35e3cecaaab7ceb0..f391ff3d2ee05d0af0d6d1f5097f0f2aa2007a09 100644

--- a/content/common/discardable_shared_memory_heap_unittest.cc

+++ b/content/common/discardable_shared_memory_heap_unittest.cc

@@ -319,7 +319,8 @@ TEST(DiscardableSharedMemoryHeapTest, CreateMemoryAllocatorDumpTest) {

// Check if allocator dump is created when span exists.

std::unique_ptr<base::trace_event::ProcessMemoryDump> pmd(

- new base::trace_event::ProcessMemoryDump(nullptr));

+ new base::trace_event::ProcessMemoryDump(

+ nullptr, {base::trace_event::MemoryDumpLevelOfDetail::DETAILED}));

EXPECT_TRUE(heap.CreateMemoryAllocatorDump(span.get(), "discardable/test1",

pmd.get()));