base/trace_event/memory_dump_request_args.h - Issue 2006943003: [tracing] Sanitize process memory dumps for background mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_request_args.h

Issue 2006943003: [tracing] Sanitize process memory dumps for background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@whitelist_mdp

Patch Set: Addressing comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/memory_dump_provider.h ('k') | base/trace_event/memory_infra_background_whitelist.h » ('j') | base/trace_event/memory_infra_background_whitelist.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/memory_dump_request_args.h

diff --git a/base/trace_event/memory_dump_request_args.h b/base/trace_event/memory_dump_request_args.h

index f78e31ce40ecedba0d90759f9c74a179aef37fa0..74ec5dc18533c446e6fbd96672b20f0672de63a2 100644

--- a/base/trace_event/memory_dump_request_args.h

+++ b/base/trace_event/memory_dump_request_args.h

@@ -60,6 +60,13 @@ struct BASE_EXPORT MemoryDumpRequestArgs {

MemoryDumpLevelOfDetail level_of_detail;

};

+// Args for ProcessMemoryDump and passed to OnMemoryDump calls for memory dump

+// providers. Dump providers are expected to read the args for creating dumps.

+struct MemoryDumpArgs {

+ // Specifies how detailed the dumps should be.

+ MemoryDumpLevelOfDetail level_of_detail;

+};

using MemoryDumpCallback = Callback<void(uint64_t dump_guid, bool success)>;

BASE_EXPORT const char* MemoryDumpTypeToString(const MemoryDumpType& dump_type);