[tracing] Sanitize process memory dumps for background mode

base/trace_event/memory_allocator_dump.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_allocator_dump.h"
 
 #include "base/format_macros.h"
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/memory_dump_provider.h"
@@ skipping 62 matching lines @@
   attributes_->BeginDictionary(name);
   attributes_->SetString("type", kTypeScalar);
   attributes_->SetString("units", units);
   attributes_->SetDouble("value", value);
   attributes_->EndDictionary();
 }
 
 void MemoryAllocatorDump::AddString(const char* name,
                                     const char* units,
                                     const std::string& value) {
+  // String attributes are disabled in background mode.
+  if (process_memory_dump_->level_of_detail() ==
+      MemoryDumpLevelOfDetail::BACKGROUND) {

[Primiano Tucci (use gerrit), 2016/05/27 17:23:35]

I wonder if we want also a NOTREACHED() here so we can detect if somebody is
wasting time pushing strings that are dropped on the floor in tests.

[ssid, 2016/05/31 22:33:20]

Done.

+    return;
+  }
+
   attributes_->BeginDictionary(name);
   attributes_->SetString("type", kTypeString);
   attributes_->SetString("units", units);
   attributes_->SetString("value", value);
   attributes_->EndDictionary();
 }
 
 void MemoryAllocatorDump::AsValueInto(TracedValue* value) const {
   value->BeginDictionaryWithCopiedName(absolute_name_);
   value->SetString("guid", guid_.ToString());
   value->SetValue("attrs", *attributes_);
   if (flags_)
     value->SetInteger("flags", flags_);
   value->EndDictionary();  // "allocator_name/heap_subheap": { ... }
 }
 
 }  // namespace trace_event
 }  // namespace base