Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: components/tracing/common/process_metrics_memory_dump_provider_unittest.cc

Issue 2006943003: [tracing] Sanitize process memory dumps for background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@whitelist_mdp
Patch Set: Fix stripping. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/tracing/common/process_metrics_memory_dump_provider.h" 5 #include "components/tracing/common/process_metrics_memory_dump_provider.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 } // namespace 121 } // namespace
122 #endif // defined(OS_LINUX) || defined(OS_ANDROID) 122 #endif // defined(OS_LINUX) || defined(OS_ANDROID)
123 123
124 TEST(ProcessMetricsMemoryDumpProviderTest, DumpRSS) { 124 TEST(ProcessMetricsMemoryDumpProviderTest, DumpRSS) {
125 const base::trace_event::MemoryDumpArgs high_detail_args = { 125 const base::trace_event::MemoryDumpArgs high_detail_args = {
126 base::trace_event::MemoryDumpLevelOfDetail::DETAILED}; 126 base::trace_event::MemoryDumpLevelOfDetail::DETAILED};
127 std::unique_ptr<ProcessMetricsMemoryDumpProvider> pmtdp( 127 std::unique_ptr<ProcessMetricsMemoryDumpProvider> pmtdp(
128 new ProcessMetricsMemoryDumpProvider(base::kNullProcessId)); 128 new ProcessMetricsMemoryDumpProvider(base::kNullProcessId));
129 std::unique_ptr<base::trace_event::ProcessMemoryDump> pmd_before( 129 std::unique_ptr<base::trace_event::ProcessMemoryDump> pmd_before(
130 new base::trace_event::ProcessMemoryDump(nullptr)); 130 new base::trace_event::ProcessMemoryDump(nullptr, high_detail_args));
131 std::unique_ptr<base::trace_event::ProcessMemoryDump> pmd_after( 131 std::unique_ptr<base::trace_event::ProcessMemoryDump> pmd_after(
132 new base::trace_event::ProcessMemoryDump(nullptr)); 132 new base::trace_event::ProcessMemoryDump(nullptr, high_detail_args));
133 133
134 ProcessMetricsMemoryDumpProvider::rss_bytes_for_testing = 1024; 134 ProcessMetricsMemoryDumpProvider::rss_bytes_for_testing = 1024;
135 pmtdp->OnMemoryDump(high_detail_args, pmd_before.get()); 135 pmtdp->OnMemoryDump(high_detail_args, pmd_before.get());
136 136
137 // Pretend that the RSS of the process increased of +1M. 137 // Pretend that the RSS of the process increased of +1M.
138 const size_t kAllocSize = 1048576; 138 const size_t kAllocSize = 1048576;
139 ProcessMetricsMemoryDumpProvider::rss_bytes_for_testing += kAllocSize; 139 ProcessMetricsMemoryDumpProvider::rss_bytes_for_testing += kAllocSize;
140 140
141 pmtdp->OnMemoryDump(high_detail_args, pmd_after.get()); 141 pmtdp->OnMemoryDump(high_detail_args, pmd_after.get());
142 142
(...skipping 20 matching lines...) Expand all
163 base::trace_event::ProcessMemoryMaps::VMRegion::kProtectionFlagsWrite; 163 base::trace_event::ProcessMemoryMaps::VMRegion::kProtectionFlagsWrite;
164 const uint32_t kProtX = 164 const uint32_t kProtX =
165 base::trace_event::ProcessMemoryMaps::VMRegion::kProtectionFlagsExec; 165 base::trace_event::ProcessMemoryMaps::VMRegion::kProtectionFlagsExec;
166 const base::trace_event::MemoryDumpArgs dump_args = { 166 const base::trace_event::MemoryDumpArgs dump_args = {
167 base::trace_event::MemoryDumpLevelOfDetail::DETAILED}; 167 base::trace_event::MemoryDumpLevelOfDetail::DETAILED};
168 168
169 std::unique_ptr<ProcessMetricsMemoryDumpProvider> pmmdp( 169 std::unique_ptr<ProcessMetricsMemoryDumpProvider> pmmdp(
170 new ProcessMetricsMemoryDumpProvider(base::kNullProcessId)); 170 new ProcessMetricsMemoryDumpProvider(base::kNullProcessId));
171 171
172 // Emulate an empty /proc/self/smaps. 172 // Emulate an empty /proc/self/smaps.
173 base::trace_event::ProcessMemoryDump pmd_invalid(nullptr /* session_state */); 173 base::trace_event::ProcessMemoryDump pmd_invalid(nullptr /* session_state */,
174 dump_args);
174 base::ScopedFILE empty_file(OpenFile(base::FilePath("/dev/null"), "r")); 175 base::ScopedFILE empty_file(OpenFile(base::FilePath("/dev/null"), "r"));
175 ASSERT_TRUE(empty_file.get()); 176 ASSERT_TRUE(empty_file.get());
176 ProcessMetricsMemoryDumpProvider::proc_smaps_for_testing = empty_file.get(); 177 ProcessMetricsMemoryDumpProvider::proc_smaps_for_testing = empty_file.get();
177 pmmdp->OnMemoryDump(dump_args, &pmd_invalid); 178 pmmdp->OnMemoryDump(dump_args, &pmd_invalid);
178 ASSERT_FALSE(pmd_invalid.has_process_mmaps()); 179 ASSERT_FALSE(pmd_invalid.has_process_mmaps());
179 180
180 // Parse the 1st smaps file. 181 // Parse the 1st smaps file.
181 base::trace_event::ProcessMemoryDump pmd_1(nullptr /* session_state */); 182 base::trace_event::ProcessMemoryDump pmd_1(nullptr /* session_state */,
183 dump_args);
182 base::ScopedFILE temp_file1; 184 base::ScopedFILE temp_file1;
183 CreateAndSetSmapsFileForTesting(kTestSmaps1, temp_file1); 185 CreateAndSetSmapsFileForTesting(kTestSmaps1, temp_file1);
184 ProcessMetricsMemoryDumpProvider::proc_smaps_for_testing = temp_file1.get(); 186 ProcessMetricsMemoryDumpProvider::proc_smaps_for_testing = temp_file1.get();
185 pmmdp->OnMemoryDump(dump_args, &pmd_1); 187 pmmdp->OnMemoryDump(dump_args, &pmd_1);
186 ASSERT_TRUE(pmd_1.has_process_mmaps()); 188 ASSERT_TRUE(pmd_1.has_process_mmaps());
187 const auto& regions_1 = pmd_1.process_mmaps()->vm_regions(); 189 const auto& regions_1 = pmd_1.process_mmaps()->vm_regions();
188 ASSERT_EQ(2UL, regions_1.size()); 190 ASSERT_EQ(2UL, regions_1.size());
189 191
190 EXPECT_EQ(0x00400000UL, regions_1[0].start_address); 192 EXPECT_EQ(0x00400000UL, regions_1[0].start_address);
191 EXPECT_EQ(0x004be000UL - 0x00400000UL, regions_1[0].size_in_bytes); 193 EXPECT_EQ(0x004be000UL - 0x00400000UL, regions_1[0].size_in_bytes);
(...skipping 11 matching lines...) Expand all
203 EXPECT_EQ(kProtW, regions_1[1].protection_flags); 205 EXPECT_EQ(kProtW, regions_1[1].protection_flags);
204 EXPECT_EQ("/file/name with space", regions_1[1].mapped_file); 206 EXPECT_EQ("/file/name with space", regions_1[1].mapped_file);
205 EXPECT_EQ(128 * 1024UL, regions_1[1].byte_stats_proportional_resident); 207 EXPECT_EQ(128 * 1024UL, regions_1[1].byte_stats_proportional_resident);
206 EXPECT_EQ(120 * 1024UL, regions_1[1].byte_stats_shared_clean_resident); 208 EXPECT_EQ(120 * 1024UL, regions_1[1].byte_stats_shared_clean_resident);
207 EXPECT_EQ(4 * 1024UL, regions_1[1].byte_stats_shared_dirty_resident); 209 EXPECT_EQ(4 * 1024UL, regions_1[1].byte_stats_shared_dirty_resident);
208 EXPECT_EQ(60 * 1024UL, regions_1[1].byte_stats_private_clean_resident); 210 EXPECT_EQ(60 * 1024UL, regions_1[1].byte_stats_private_clean_resident);
209 EXPECT_EQ(8 * 1024UL, regions_1[1].byte_stats_private_dirty_resident); 211 EXPECT_EQ(8 * 1024UL, regions_1[1].byte_stats_private_dirty_resident);
210 EXPECT_EQ(0 * 1024UL, regions_1[1].byte_stats_swapped); 212 EXPECT_EQ(0 * 1024UL, regions_1[1].byte_stats_swapped);
211 213
212 // Parse the 2nd smaps file. 214 // Parse the 2nd smaps file.
213 base::trace_event::ProcessMemoryDump pmd_2(nullptr /* session_state */); 215 base::trace_event::ProcessMemoryDump pmd_2(nullptr /* session_state */,
216 dump_args);
214 base::ScopedFILE temp_file2; 217 base::ScopedFILE temp_file2;
215 CreateAndSetSmapsFileForTesting(kTestSmaps2, temp_file2); 218 CreateAndSetSmapsFileForTesting(kTestSmaps2, temp_file2);
216 ProcessMetricsMemoryDumpProvider::proc_smaps_for_testing = temp_file2.get(); 219 ProcessMetricsMemoryDumpProvider::proc_smaps_for_testing = temp_file2.get();
217 pmmdp->OnMemoryDump(dump_args, &pmd_2); 220 pmmdp->OnMemoryDump(dump_args, &pmd_2);
218 ASSERT_TRUE(pmd_2.has_process_mmaps()); 221 ASSERT_TRUE(pmd_2.has_process_mmaps());
219 const auto& regions_2 = pmd_2.process_mmaps()->vm_regions(); 222 const auto& regions_2 = pmd_2.process_mmaps()->vm_regions();
220 ASSERT_EQ(1UL, regions_2.size()); 223 ASSERT_EQ(1UL, regions_2.size());
221 EXPECT_EQ(0x7fe7ce79c000UL, regions_2[0].start_address); 224 EXPECT_EQ(0x7fe7ce79c000UL, regions_2[0].start_address);
222 EXPECT_EQ(0x7fe7ce7a8000UL - 0x7fe7ce79c000UL, regions_2[0].size_in_bytes); 225 EXPECT_EQ(0x7fe7ce7a8000UL - 0x7fe7ce79c000UL, regions_2[0].size_in_bytes);
223 EXPECT_EQ(0U, regions_2[0].protection_flags); 226 EXPECT_EQ(0U, regions_2[0].protection_flags);
224 EXPECT_EQ("", regions_2[0].mapped_file); 227 EXPECT_EQ("", regions_2[0].mapped_file);
225 EXPECT_EQ(32 * 1024UL, regions_2[0].byte_stats_proportional_resident); 228 EXPECT_EQ(32 * 1024UL, regions_2[0].byte_stats_proportional_resident);
226 EXPECT_EQ(16 * 1024UL, regions_2[0].byte_stats_shared_clean_resident); 229 EXPECT_EQ(16 * 1024UL, regions_2[0].byte_stats_shared_clean_resident);
227 EXPECT_EQ(12 * 1024UL, regions_2[0].byte_stats_shared_dirty_resident); 230 EXPECT_EQ(12 * 1024UL, regions_2[0].byte_stats_shared_dirty_resident);
228 EXPECT_EQ(8 * 1024UL, regions_2[0].byte_stats_private_clean_resident); 231 EXPECT_EQ(8 * 1024UL, regions_2[0].byte_stats_private_clean_resident);
229 EXPECT_EQ(4 * 1024UL, regions_2[0].byte_stats_private_dirty_resident); 232 EXPECT_EQ(4 * 1024UL, regions_2[0].byte_stats_private_dirty_resident);
230 EXPECT_EQ(0 * 1024UL, regions_2[0].byte_stats_swapped); 233 EXPECT_EQ(0 * 1024UL, regions_2[0].byte_stats_swapped);
231 } 234 }
232 #endif // defined(OS_LINUX) || defined(OS_ANDROID) 235 #endif // defined(OS_LINUX) || defined(OS_ANDROID)
233 236
234 } // namespace tracing 237 } // namespace tracing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698