Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2006943002: remove includes for duplicate functions (Closed)

Created:
4 years, 7 months ago by fbarchard1
Modified:
4 years, 7 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

remove includes for duplicate functions R=harryjin@google.com BUG=libyuv:592 TESTED=local builds work with fewer headers Committed: https://chromium.googlesource.com/libyuv/libyuv/+/7edf572e282e60722ffad21c5eb7b627548b1a18

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : merge sorted includes in unittest #

Patch Set 4 : tried removing row.h but its needed for alloc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/convert.h View 1 chunk +2 lines, -4 lines 0 comments Download
M include/libyuv/convert_argb.h View 1 chunk +2 lines, -4 lines 0 comments Download
M include/libyuv/convert_from.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/convert_argb.cc View 1 chunk +1 line, -0 lines 0 comments Download
M source/convert_jpeg.cc View 1 chunk +1 line, -0 lines 0 comments Download
M unit_test/scale_argb_test.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
fbarchard1
4 years, 7 months ago (2016-05-23 22:03:02 UTC) #1
harryjin
lgtm
4 years, 7 months ago (2016-05-23 23:28:47 UTC) #2
fbarchard1
4 years, 7 months ago (2016-05-24 00:38:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7edf572e282e60722ffad21c5eb7b627548b1a18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698