Issue 200693006: Remove --enable-unrestricted-ssl3-fallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200693006: Remove --enable-unrestricted-ssl3-fallback. (Closed)

Created:
6 years, 9 months ago by Peter Kasting

Modified:
6 years, 9 months ago

Reviewers:
James Hawkins, wtc, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, agl

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Remove --enable-unrestricted-ssl3-fallback. It looks like this isn't actually wired to anything. BUG=354947 TEST=none R=jhawkins@chromium.org, rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258714

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -60 lines)			Patch
M	chrome/browser/net/ssl_config_service_manager_pref.cc	View	4 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/net/ssl_config_service_manager_pref_unittest.cc	View	7 chunks	+2 lines, -22 lines	0 comments	Download
M	chrome/browser/prefs/command_line_pref_store.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/ssl/ssl_config_service.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	net/ssl/ssl_config_service.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	net/ssl/ssl_config_service_unittest.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

Peter Kasting

rsleevi: Review jhawkins: chrome/ OWNERs Should be easy, just removing code.

6 years, 9 months ago (2014-03-21 22:04:07 UTC) #1

Ryan Sleevi

LGTM. After seeing how horrible a cesspool the Internet is, we've went a different engineering ...

6 years, 9 months ago (2014-03-21 22:58:10 UTC) #3

Peter Kasting

Committed patchset #1 manually as r258714 (presubmit successful).

6 years, 9 months ago (2014-03-22 00:26:56 UTC) #4

Message was sent while issue was closed.

Patch set 1 LGTM.