Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 200693004: Remove unused defines and includes from FontPlatformDataWin (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Remove unused defines and includes from FontPlatformDataWin Now that we no longer have HFONT references in FontPlatformDataWin we can remove a bunch of defines and includes. R=schenney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/platform/fonts/win/FontPlatformDataWin.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eae
6 years, 9 months ago (2014-03-21 21:15:39 UTC) #1
Stephen Chennney
LGTM. Android build failure is unrelated.
6 years, 9 months ago (2014-03-21 21:22:49 UTC) #2
eae
On 2014/03/21 21:22:49, Stephen Chenney wrote: > LGTM. Android build failure is unrelated. Thanks!
6 years, 9 months ago (2014-03-21 21:23:57 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-21 21:24:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/200693004/1
6 years, 9 months ago (2014-03-21 21:24:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 21:37:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-21 21:37:10 UTC) #7
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-21 21:37:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/200693004/1
6 years, 9 months ago (2014-03-21 21:37:59 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 04:18:25 UTC) #10
Message was sent while issue was closed.
Change committed as 169779

Powered by Google App Engine
This is Rietveld 408576698