components/offline_pages/archive_manager.h - Issue 2006923005: [Offline Pages] Two-step expiration in storage manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/archive_manager.h

Issue 2006923005: [Offline Pages] Two-step expiration in storage manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing unittest on win. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/archive_manager.h

diff --git a/components/offline_pages/archive_manager.h b/components/offline_pages/archive_manager.h

index 23e29c14e29ad9607273188e9dc172d28788404a..c338162aea2ed60c978b82ffcfaf21c5b47b1101 100644

--- a/components/offline_pages/archive_manager.h

+++ b/components/offline_pages/archive_manager.h

@@ -47,7 +47,7 @@ class ArchiveManager {

// Deletes multiple archives that are specified in |archive_paths|.

// It is considered successful to attempt to delete a file that does not

- // exist.

+ // exist, or |archive_path| is empty.

jianli 2016/05/26 21:59:31 Adding this behavior seems to be confusing.

romax 2016/05/27 00:41:37 removed

virtual void DeleteMultipleArchives(

const std::vector<base::FilePath>& archive_paths,

const base::Callback<void(bool)>& callback);

« no previous file with comments | « no previous file | components/offline_pages/archive_manager.cc » ('j') | components/offline_pages/offline_page_model.cc » ('J')