components/offline_pages/archive_manager.cc - Issue 2006923005: [Offline Pages] Two-step expiration in storage manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/archive_manager.cc

Issue 2006923005: [Offline Pages] Two-step expiration in storage manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/archive_manager.h ('k') | components/offline_pages/offline_page_client_policy.h » ('j') | components/offline_pages/offline_page_storage_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/archive_manager.cc

diff --git a/components/offline_pages/archive_manager.cc b/components/offline_pages/archive_manager.cc

index 8df6b541e346fc0d63b8f7a9f63cd11edeee99cf..4b2494c815078cda01971c11b67f37a3002122ff 100644

--- a/components/offline_pages/archive_manager.cc

+++ b/components/offline_pages/archive_manager.cc

@@ -40,6 +40,8 @@ void DeleteArchivesImpl(const std::vector<base::FilePath>& file_paths,

// Make sure delete happens on the left of || so that it is always executed.

result = base::DeleteFile(file_path, false) || result;

}

+ if (file_paths.size() == 0)

+ result = true;

task_runner->PostTask(FROM_HERE, base::Bind(callback, result));

}