Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 2006923005: [Offline Pages] Two-step expiration in storage manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_unittest.cc
diff --git a/components/offline_pages/offline_page_model_unittest.cc b/components/offline_pages/offline_page_model_unittest.cc
index 34840eacfca88a3b004c919ee32106ee66f08c28..581c631d3dffd285fe008a9980aafa6684ef8f0c 100644
--- a/components/offline_pages/offline_page_model_unittest.cc
+++ b/components/offline_pages/offline_page_model_unittest.cc
@@ -975,7 +975,9 @@ TEST_F(OfflinePageModelTest, ExpirePages) {
base::Time expiration_time =
base::Time::Now() + base::TimeDelta::FromMinutes(5);
- model()->ExpirePages(pages_to_expire, expiration_time);
+ model()->ExpirePages(
+ pages_to_expire, expiration_time,
+ base::Bind(&OfflinePageModelTest::OnDeletePageDone, AsWeakPtr()));
PumpLoop();
const std::vector<OfflinePageItem>& offline_pages = GetAllPages();
@@ -989,6 +991,7 @@ TEST_F(OfflinePageModelTest, ExpirePages) {
EXPECT_FALSE(offline_page.IsExpired());
}
}
+ EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
}
TEST(CommandLineFlagsTest, OfflineBookmarks) {

Powered by Google App Engine
This is Rietveld 408576698