[Offline Pages] Two-step expiration in storage manager.

components/offline_pages/offline_page_storage_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_STORAGE_MANAGER_H_
 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_STORAGE_MANAGER_H_
 
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "components/offline_pages/archive_manager.h"
 #include "components/offline_pages/offline_page_types.h"
 
 namespace base {
 class Clock;
 }  // namespace base
 
 namespace offline_pages {
 
-// Limit of the total storage space occupied by offline pages should be 30% of
-// available storage. And we clear storage when it is over the threshold,
-// reducing the usage below threshold.
+// Maximum % of total available storage that will be occupied by offline pages
+// before a storage clearup.
 const double kOfflinePageStorageLimit = 0.3;
+// The target % of storage usage we try to reach below when expiring pages.
 const double kOfflinePageStorageClearThreshold = 0.1;
+// The time that the storage cleanup will be triggered again since the last one.
 const base::TimeDelta kClearStorageInterval = base::TimeDelta::FromMinutes(10);
+// The time that the page record will be removed from the store since the page
+// has been expired.
+const base::TimeDelta kRemovePageItemInterval = base::TimeDelta::FromDays(21);
 
 class ArchiveManager;
 class ClientPolicyController;
 
 // This class is used for storage management of offline pages. It provides
 // a ClearPagesIfNeeded method which is used to clear expired offline pages
 // based on last_access_time and lifetime policy of its namespace.
 // It has its own throttle mechanism so calling the method would not be
 // guaranteed to clear the pages immediately.
 //
 // OfflinePageModel should own and control the lifecycle of this manager.
 // And this manager would use OfflinePageModel to get/remove pages.
 class OfflinePageStorageManager {
  public:
   // This interface should have no knowledge of offline page model.
   // This interface should be implemented by clients managed by storage manager.
   class Client {
    public:
     virtual ~Client() {}
 
+    // Asks the client to delete pages based on |ofline_ids| and invokes
+    // |callback| upon completion.
+    virtual void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
+                                        const DeletePageCallback& callback) = 0;
+
     // Asks the client to get all offline pages and invoke |callback|.

[jianli, 2016/05/27 00:57:17]

nit: invokes |callback| upon completion.

[romax, 2016/05/27 02:18:26]

Done.

     virtual void GetAllPages(
         const MultipleOfflinePageItemCallback& callback) = 0;
 
-    // Asks the client to delete pages based on |offline_ids| and invoke
-    // |callback|.
-    virtual void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
-                                        const DeletePageCallback& callback) = 0;
+    // Asks the client to mark pages with |offline_ids| as expired and delete
+    // the associated archive files.
+    virtual void ExpirePages(const std::vector<int64_t>& offline_ids,
+                             const base::Time& expiration_time,
+                             const base::Callback<void(bool)>& callback) = 0;
   };
 
   enum class ClearStorageResult {
     SUCCESS,         // Cleared successfully.
     UNNECESSARY,     // No expired pages.
+    EXPIRE_FAILURE,  // Expiration failed.
     DELETE_FAILURE,  // Deletion failed.
+    BOTH_FAILURE,    // Both expiration and deletion failed.

[jianli, 2016/05/27 00:57:17]

Probably better to say EXPIRE_AND_DELETE_FAILURES in case that we might add
other failure case in the future.

[romax, 2016/05/27 02:18:26]

Done.

   };
 
   // Callback used when calling ClearPagesIfNeeded.
-  // int: the number of expired pages.
+  // size_t: the number of expired pages.
   // ClearStorageResult: result of expiring pages in storage.
-  typedef base::Callback<void(int, ClearStorageResult)> ClearPagesCallback;
+  typedef base::Callback<void(size_t, ClearStorageResult)> ClearPagesCallback;
 
   explicit OfflinePageStorageManager(Client* client,
                                      ClientPolicyController* policy_controller,
                                      ArchiveManager* archive_manager);
 
   ~OfflinePageStorageManager();
 
   // The manager would *try* to clear pages when called. It may not delete any
   // pages (if clearing condition wasn't satisfied).
   // It clears the storage (expire pages) when it's using more disk space than a
   // certain limit, or the time elapsed from last time clearing is longer than a
   // certain interval. Both values are defined above.
   void ClearPagesIfNeeded(const ClearPagesCallback& callback);
 
   // Sets the clock for testing.
   void SetClockForTesting(std::unique_ptr<base::Clock> clock);
 
  private:
   // Enum indicating how to clear the pages.
   enum class ClearMode {
     // Using normal expiration logic to expire pages. Will reduce the storage
     // usage down below the threshold.
     DEFAULT,
     // No need to expire any page (no pages in the model or no expired
     // pages and we're not exceeding the storage limit.)
     NOT_NEEDED,
   };
 
   // Callback called after getting storage stats from archive manager.
-  void OnGetStorageStatsDone(const ClearPagesCallback& callback,
-                             const ArchiveManager::StorageStats& pages);
+  void OnGetStorageStatsDoneForClearingPages(
+      const ClearPagesCallback& callback,
+      const ArchiveManager::StorageStats& pages);
 
   // Callback called after getting all pages from client done.

[jianli, 2016/05/27 00:57:17]

nit: remove "done" from comment

[romax, 2016/05/27 02:18:26]

Done.

-  void OnGetAllPagesDone(const ClearPagesCallback& callback,
-                         const ArchiveManager::StorageStats& storage_stats,
-                         const MultipleOfflinePageItemResult& pages);
+  void OnGetAllPagesDoneForClearingPages(
+      const ClearPagesCallback& callback,
+      const ArchiveManager::StorageStats& storage_stats,
+      const MultipleOfflinePageItemResult& pages);
 
   // Callback called after expired pages have been deleted.
-  void OnExpiredPagesDeleted(const ClearPagesCallback& callback,
-                             int pages_to_clear,
-                             DeletePageResult result);
+  void OnPagesExpired(const ClearPagesCallback& callback,
+                      size_t pages_to_clear,
+                      const std::vector<int64_t>& page_ids_to_remove,
+                      bool expiration_succeeded);
 
-  // Gets offline IDs of all expired pages and return in |offline_ids|.
-  void GetExpiredPageIds(const MultipleOfflinePageItemResult& pages,
+  // Callback called after clearing outdated pages from client.
+  void OnOutdatedPagesCleared(const ClearPagesCallback& callback,
+                              size_t pages_cleared,
+                              bool expiration_succeeded,
+                              DeletePageResult result);
+
+  // Gets offline IDs of both pages that should be expired and the ones that
+  // need to be removed from metadata store. |page_ids_to_expire| will have
+  // the pages to be expired, |page_ids_to_remove| will have the pages to be
+  // removed.
+  void GetPageIdsToClear(const MultipleOfflinePageItemResult& pages,
                          const ArchiveManager::StorageStats& stats,
-                         std::vector<int64_t>& offline_ids);
+                         std::vector<int64_t>* page_ids_to_expire,
+                         std::vector<int64_t>* page_ids_to_remove);
 
-  // Determine if manager should clear pages.
+  // Determines if manager should clear pages.
   ClearMode ShouldClearPages(const ArchiveManager::StorageStats& storage_stats);
 
-  // Return true if |page| is expired comparing to |now|.
-  bool ShouldBeExpired(const base::Time& now, const OfflinePageItem& page);
+  // Returns true if |page| is expired comparing to |clear_time_|.
+  bool ShouldBeExpired(const OfflinePageItem& page);

[jianli, 2016/05/27 00:57:17]

add const modifier

[romax, 2016/05/27 02:18:26]

Done.

+
+  // Returns true if we're currently doing a cleanup.
+  bool IsInProgress();

[jianli, 2016/05/27 00:57:17]

nit: add const modifier

[romax, 2016/05/27 02:18:26]

Done.

 
   // Not owned.
   Client* client_;
 
   // Not owned.
   ClientPolicyController* policy_controller_;
 
   // Not owned.
   ArchiveManager* archive_manager_;
 
-  bool in_progress_;
+  // Starting time of the current storage cleanup. If this time is later than
+  // |last_clear_time_| it means we're doing a cleanup.
+  base::Time clear_time_;
 
+  // Timestamp of last storage cleanup.
   base::Time last_clear_time_;
 
   // Clock for getting time.
   std::unique_ptr<base::Clock> clock_;
 
   base::WeakPtrFactory<OfflinePageStorageManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflinePageStorageManager);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_STORAGE_MANAGER_H_