Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: tools/gn/ninja_build_writer_unittest.cc

Issue 2006923004: Add support for user defined "pool" to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_build_writer_unittest.cc
diff --git a/tools/gn/ninja_build_writer_unittest.cc b/tools/gn/ninja_build_writer_unittest.cc
index 48d73028e177ae4bc7e6f4748428dcc748670024..955eb1c110ea0df331d40a789fee1b0eafe7d21c 100644
--- a/tools/gn/ninja_build_writer_unittest.cc
+++ b/tools/gn/ninja_build_writer_unittest.cc
@@ -6,6 +6,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/gn/ninja_build_writer.h"
+#include "tools/gn/pool.h"
#include "tools/gn/scheduler.h"
#include "tools/gn/target.h"
#include "tools/gn/test_with_scope.h"
@@ -31,12 +32,19 @@ TEST(NinjaBuildWriter, TwoTargets) {
target_bar.SetToolchain(setup.toolchain());
ASSERT_TRUE(target_bar.OnResolved(&err));
+ Pool swiming_pool(setup.settings(),
+ Label(SourceDir("//swiming/"), "pool",
+ SourceDir("//other/"), "toolchain"));
+ swiming_pool.set_depth(42);
+
std::ostringstream ninja_out;
std::ostringstream depfile_out;
std::vector<const Settings*> all_settings = {setup.settings()};
std::vector<const Target*> targets = {&target_foo, &target_bar};
+ std::vector<const Pool*> all_pools = {&swiming_pool};
NinjaBuildWriter writer(setup.build_settings(), all_settings,
- setup.toolchain(), targets, ninja_out, depfile_out);
+ setup.toolchain(), targets, all_pools, ninja_out,
+ depfile_out);
ASSERT_TRUE(writer.Run(&err));
const char expected_rule_gn[] = "rule gn\n";
@@ -48,6 +56,9 @@ TEST(NinjaBuildWriter, TwoTargets) {
const char expected_link_pool[] =
"pool link_pool\n"
" depth = 0\n"
+ "\n"
+ "pool other_toolchain_swiming_pool\n"
+ " depth = 42\n"
"\n";
const char expected_toolchain[] =
"subninja toolchain.ninja\n"
@@ -102,8 +113,10 @@ TEST(NinjaBuildWriter, DuplicateOutputs) {
std::ostringstream depfile_out;
std::vector<const Settings*> all_settings = { setup.settings() };
std::vector<const Target*> targets = { &target_foo, &target_bar };
+ std::vector<const Pool*> all_pools;
NinjaBuildWriter writer(setup.build_settings(), all_settings,
- setup.toolchain(), targets, ninja_out, depfile_out);
+ setup.toolchain(), targets, all_pools, ninja_out,
+ depfile_out);
ASSERT_FALSE(writer.Run(&err));
const char expected_help_test[] =

Powered by Google App Engine
This is Rietveld 408576698