Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2006893002: Video Gmb Pool: Plumb GpuMemoryBufferId through to compositor (Closed)

Created:
4 years, 7 months ago by ccameron
Modified:
4 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, cc-bugs_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Video Gmb Pool: Plumb GpuMemoryBufferId through to compositor Add a function WrapGpuMemoryBufferBackedNativeTextures, which is like WrapNativeTextures, but specifying GpuMemoryBufferIds for the textures, which is then passed along to the compositor (as opposed to the current behavior, where we just pass an invalid id). BUG=604052 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a386d2f6f425b9205d53ee6443910a3b2ef8dba6 Cr-Commit-Position: refs/heads/master@{#395454}

Patch Set 1 #

Patch Set 2 : Remove dependency on previous patch #

Patch Set 3 : Add gmb ID support to unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -16 lines) Patch
M cc/resources/video_resource_updater.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M media/base/video_frame.h View 3 chunks +19 lines, -0 lines 0 comments Download
M media/base/video_frame.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 3 chunks +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
ccameron
ptal
4 years, 7 months ago (2016-05-23 20:39:08 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-23 20:42:17 UTC) #4
ccameron
Thanks!
4 years, 7 months ago (2016-05-23 20:45:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006893002/20001
4 years, 7 months ago (2016-05-23 20:45:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/164950)
4 years, 7 months ago (2016-05-23 21:11:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006893002/40001
4 years, 7 months ago (2016-05-23 21:50:39 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-23 23:15:59 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 23:17:44 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a386d2f6f425b9205d53ee6443910a3b2ef8dba6
Cr-Commit-Position: refs/heads/master@{#395454}

Powered by Google App Engine
This is Rietveld 408576698