Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006823002: Mojo C++ bindings: move support for mojo::String. (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: move support for mojo::String. BUG=593220 Committed: https://crrev.com/0b3918953d5aac5a179fca9370a17a801f45d874 Cr-Commit-Position: refs/heads/master@{#395448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -8 lines) Patch
M mojo/public/cpp/bindings/string.h View 3 chunks +25 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/string_unittest.cc View 3 chunks +46 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 7 months ago (2016-05-23 18:32:14 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-05-23 22:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006823002/1
4 years, 6 months ago (2016-05-23 22:51:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-23 22:56:41 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-23 22:58:42 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0b3918953d5aac5a179fca9370a17a801f45d874
Cr-Commit-Position: refs/heads/master@{#395448}

Powered by Google App Engine
This is Rietveld 408576698