[prof] Add slide offset in dumpcpp script

[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=v8:5048
Committed: https://crrev.com/ac3edd40af355202efcdc203ba1eec49ff76c195
Cr-Commit-Position: refs/heads/master@{#36574}

[lpy, 2016-05-23 18:23:53]

lpy@chromium.org changed reviewers:
+ fmeawad@chromium.org, jarin@chromium.org, jochen@chromium.org,
machenbach@chromium.org, yangguo@chromium.org

[lpy, 2016-05-23 18:23:53]

PTAL.

[lpy, 2016-05-25 21:53:57]

gentle ping for review.

[fmeawad, 2016-05-25 23:11:47]

On 2016/05/25 21:53:57, lpy wrote:
> gentle ping for review.

Can you add a bug # and explain the cause of the bug, also is there a way to add
a unittest to prevent that from happening again?

[lpy, 2016-05-26 20:18:11]

Description was changed from

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=
==========

to

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=5048
==========

[lpy, 2016-05-26 20:19:50]

On 2016/05/25 23:11:47, fmeawad wrote:
> On 2016/05/25 21:53:57, lpy wrote:
> > gentle ping for review.
> 
> Can you add a bug # and explain the cause of the bug, also is there a way to
add
> a unittest to prevent that from happening again?

Done, ptal.

Also I moved the execution of CppProcessor into dumpcpp-driver.js in order to
load dumpcpp.js to test.

[fmeawad, 2016-05-27 22:33:50]

lgtm

https://codereview.chromium.org/2006813002/diff/20001/test/mjsunit/mjsunit.is...
File test/mjsunit/mjsunit.isolate (right):

https://codereview.chromium.org/2006813002/diff/20001/test/mjsunit/mjsunit.is...
test/mjsunit/mjsunit.isolate:17: '../../tools/dumpcpp.js'
reorder alphabeticaly

[Michael Achenbach, 2016-05-30 08:26:45]

Description was changed from

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=5048
==========

to

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=v8:5048
==========

[Michael Achenbach, 2016-05-30 08:27:41]

lgtm

[lpy, 2016-05-30 08:31:45]

The CQ bit was checked by lpy@chromium.org

[commit-bot: I haz the power, 2016-05-30 08:31:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006813002/20001

[commit-bot: I haz the power, 2016-05-30 08:55:37]

Description was changed from

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=v8:5048
==========

to

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=v8:5048
==========

[commit-bot: I haz the power, 2016-05-30 08:55:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-30 08:57:06]

Description was changed from

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=v8:5048
==========

to

==========
[prof] Add slide offset in dumpcpp script

An additional slide offset is exported into `shared-library`, which is used to
symbolize C++ stack on systems with ASLR (OS X).

This patch adds slide offset support in dumpcpp script.

BUG=v8:5048

Committed: https://crrev.com/ac3edd40af355202efcdc203ba1eec49ff76c195
Cr-Commit-Position: refs/heads/master@{#36574}
==========

[commit-bot: I haz the power, 2016-05-30 08:57:07]

Patchset 2 (id:??) landed as
https://crrev.com/ac3edd40af355202efcdc203ba1eec49ff76c195
Cr-Commit-Position: refs/heads/master@{#36574}