Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pdf/pdfium/pdfium_engine.h

Issue 2006793003: PDF: Always call FPDFAvail_IsDocAvail() when loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | pdf/pdfium/pdfium_engine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_engine.h
diff --git a/pdf/pdfium/pdfium_engine.h b/pdf/pdfium/pdfium_engine.h
index ec3c80dcce9376ea7b79441ede33ba8995a2b355..dcfbe3d132b4371903be57fd5cd17e21304d2993 100644
--- a/pdf/pdfium/pdfium_engine.h
+++ b/pdf/pdfium/pdfium_engine.h
@@ -212,7 +212,7 @@ class PDFiumEngine : public PDFEngine,
const std::string& password,
bool* needs_password);
- // Ask the user for the document password and then continue loading the
+ // Asks the user for the document password and then continue loading the
// document.
void GetPasswordAndLoad();
@@ -225,17 +225,19 @@ class PDFiumEngine : public PDFEngine,
void ContinueLoadingDocument(bool has_password,
const std::string& password);
- // Finish loading the document and notify the client that the document has
- // been loaded. This should only be run after |doc_| has been loaded and the
- // document is fully downloaded. If this has been run once, it will result in
- // a no-op.
+ // Finishes loading the document. Recalculate the document size if there were
+ // pages that were not previously available.
+ // Also notifies the client that the document has been loaded.
+ // This should only be called after |doc_| has been loaded and the document is
+ // fully downloaded.
+ // If this has been run once, it will not notify the client again.
void FinishLoadingDocument();
// Loads information about the pages in the document and calculate the
// document size.
void LoadPageInfo(bool reload);
- // Calculate which pages should be displayed right now.
+ // Calculates which pages should be displayed right now.
void CalculateVisiblePages();
// Returns true iff the given page index is visible. CalculateVisiblePages
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | pdf/pdfium/pdfium_engine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698