Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: pdf/pdfium/pdfium_engine.h

Issue 2006793003: PDF: Always call FPDFAvail_IsDocAvail() when loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: call FPDFAvail_IsDocAvail one more time Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_engine.h
diff --git a/pdf/pdfium/pdfium_engine.h b/pdf/pdfium/pdfium_engine.h
index a4958450ff760d977751a55263304a5109aee90c..a6b5eabc6e24f1fe79a68c29513efff96139ddd5 100644
--- a/pdf/pdfium/pdfium_engine.h
+++ b/pdf/pdfium/pdfium_engine.h
@@ -218,7 +218,7 @@ class PDFiumEngine : public PDFEngine,
// and needs a password, |needs_password| will be set to true.
bool TryLoadingDoc(const std::string& password, bool* needs_password);
- // Ask the user for the document password and then continue loading the
+ // Asks the user for the document password and then continue loading the
// document.
void GetPasswordAndLoad();
@@ -230,17 +230,19 @@ class PDFiumEngine : public PDFEngine,
// there is no password. If there is no password, then |password| is empty.
void ContinueLoadingDocument(const std::string& password);
- // Finish loading the document and notify the client that the document has
- // been loaded. This should only be run after |doc_| has been loaded and the
- // document is fully downloaded. If this has been run once, it will result in
- // a no-op.
+ // Finishes loading the document. Recalculate the document size if there were
+ // pages that were not previously available.
+ // Also notifies the client that the document has been loaded.
+ // This should only be called after |doc_| has been loaded and the document is
+ // fully downloaded.
+ // If this has been run once, it will not notify the client again.
void FinishLoadingDocument();
// Loads information about the pages in the document and calculate the
// document size.
void LoadPageInfo(bool reload);
- // Calculate which pages should be displayed right now.
+ // Calculates which pages should be displayed right now.
void CalculateVisiblePages();
// Returns true iff the given page index is visible. CalculateVisiblePages
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698