runtime/vm/weak_code.cc - Issue 2006793002: VM: Fix race between background compiler and guarded cid update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/weak_code.cc

Issue 2006793002: VM: Fix race between background compiler and guarded cid update. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rework how we invalidate background compiled code Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/weak_code.cc

diff --git a/runtime/vm/weak_code.cc b/runtime/vm/weak_code.cc

index 1305443c33e909a57ffd00c6c814fd5c2ace3cb3..6dedc88f35f2f60fe5173671745790d6a63860a0 100644

--- a/runtime/vm/weak_code.cc

+++ b/runtime/vm/weak_code.cc

@@ -61,7 +61,6 @@ bool WeakCodeReferences::IsOptimizedCode(const Array& dependent_code,

void WeakCodeReferences::DisableCode() {

- IncrementInvalidationGen();

const Array& code_objects = Array::Handle(array_.raw());

if (code_objects.IsNull()) {

return;

« no previous file with comments | « runtime/vm/weak_code.h ('k') | no next file » | no next file with comments »