Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: runtime/vm/weak_code.h

Issue 2006793002: VM: Fix race between background compiler and guarded cid update. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rework how we invalidate background compiled code Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/weak_code.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_WEAK_CODE_H_ 5 #ifndef VM_WEAK_CODE_H_
6 #define VM_WEAK_CODE_H_ 6 #define VM_WEAK_CODE_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 10
11 namespace dart { 11 namespace dart {
12 12
13 class Array; 13 class Array;
14 class Code; 14 class Code;
15 15
16 // Helper class to handle an array of code weak properties. Implements 16 // Helper class to handle an array of code weak properties. Implements
17 // registration and disabling of stored code objects. 17 // registration and disabling of stored code objects.
18 class WeakCodeReferences : public ValueObject { 18 class WeakCodeReferences : public ValueObject {
19 public: 19 public:
20 explicit WeakCodeReferences(const Array& value) : array_(value) {} 20 explicit WeakCodeReferences(const Array& value) : array_(value) {}
21 virtual ~WeakCodeReferences() {} 21 virtual ~WeakCodeReferences() {}
22 22
23 void Register(const Code& value); 23 void Register(const Code& value);
24 24
25 virtual void UpdateArrayTo(const Array& array) = 0; 25 virtual void UpdateArrayTo(const Array& array) = 0;
26 virtual void ReportDeoptimization(const Code& code) = 0; 26 virtual void ReportDeoptimization(const Code& code) = 0;
27 virtual void ReportSwitchingCode(const Code& code) = 0; 27 virtual void ReportSwitchingCode(const Code& code) = 0;
28 virtual void IncrementInvalidationGen() = 0;
29 28
30 static bool IsOptimizedCode(const Array& dependent_code, const Code& code); 29 static bool IsOptimizedCode(const Array& dependent_code, const Code& code);
31 30
32 void DisableCode(); 31 void DisableCode();
33 32
34 bool HasCodes() const; 33 bool HasCodes() const;
35 34
36 private: 35 private:
37 const Array& array_; // Array of Code objects. 36 const Array& array_; // Array of Code objects.
38 DISALLOW_COPY_AND_ASSIGN(WeakCodeReferences); 37 DISALLOW_COPY_AND_ASSIGN(WeakCodeReferences);
39 }; 38 };
40 39
41 } // namespace dart 40 } // namespace dart
42 41
43 #endif // VM_WEAK_CODE_H_ 42 #endif // VM_WEAK_CODE_H_
OLDNEW
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/weak_code.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698