Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: runtime/vm/weak_code.cc

Issue 2006793002: VM: Fix race between background compiler and guarded cid update. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rework how we invalidate background compiled code Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/weak_code.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/weak_code.h" 5 #include "vm/weak_code.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 8
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 weak_property ^= dependent_code.At(i); 54 weak_property ^= dependent_code.At(i);
55 if (code.raw() == weak_property.key()) { 55 if (code.raw() == weak_property.key()) {
56 return true; 56 return true;
57 } 57 }
58 } 58 }
59 return false; 59 return false;
60 } 60 }
61 61
62 62
63 void WeakCodeReferences::DisableCode() { 63 void WeakCodeReferences::DisableCode() {
64 IncrementInvalidationGen();
65 const Array& code_objects = Array::Handle(array_.raw()); 64 const Array& code_objects = Array::Handle(array_.raw());
66 if (code_objects.IsNull()) { 65 if (code_objects.IsNull()) {
67 return; 66 return;
68 } 67 }
69 ASSERT(!FLAG_precompiled_runtime); 68 ASSERT(!FLAG_precompiled_runtime);
70 UpdateArrayTo(Object::null_array()); 69 UpdateArrayTo(Object::null_array());
71 // Disable all code on stack. 70 // Disable all code on stack.
72 Code& code = Code::Handle(); 71 Code& code = Code::Handle();
73 { 72 {
74 DartFrameIterator iterator; 73 DartFrameIterator iterator;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 // Make non-OSR code non-entrant. 126 // Make non-OSR code non-entrant.
128 if (!code.IsDisabled()) { 127 if (!code.IsDisabled()) {
129 ReportSwitchingCode(code); 128 ReportSwitchingCode(code);
130 code.DisableDartCode(); 129 code.DisableDartCode();
131 } 130 }
132 } 131 }
133 } 132 }
134 } 133 }
135 134
136 } // namespace dart 135 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/weak_code.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698