Notification badges are only supported on Android.

Notification badges are only supported on Android.

BUG=591394
Committed: https://crrev.com/beb6b08839769066c793cfd63757dbb223c1a275
Cr-Commit-Position: refs/heads/master@{#395622}

[Michael van Ouwerkerk, 2016-05-23 15:36:04]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 15:36:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006743002/1

[Michael van Ouwerkerk, 2016-05-23 15:36:41]

mvanouwerkerk@chromium.org changed reviewers:
+ peter@chromium.org

[Michael van Ouwerkerk, 2016-05-23 15:36:41]

Peter, could you take a look please?

[Peter Beverloo, 2016-05-23 15:40:03]

lgtm

https://codereview.chromium.org/2006743002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/platform_notification_service_impl.cc (right):

https://codereview.chromium.org/2006743002/diff/1/chrome/browser/notification...
chrome/browser/notifications/platform_notification_service_impl.cc:472: //
Badges are only supported on Android: crbug.com/591394#c4
Can we summarize the reasoning here rather than link to the bug?

I'd also like to see a TODO here to make sure that
|notification_resources.badge| drawsNothing() on other platforms.

[Michael van Ouwerkerk, 2016-05-23 16:12:26]

Thanks Peter.

https://codereview.chromium.org/2006743002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/platform_notification_service_impl.cc (right):

https://codereview.chromium.org/2006743002/diff/1/chrome/browser/notification...
chrome/browser/notifications/platform_notification_service_impl.cc:472: //
Badges are only supported on Android: crbug.com/591394#c4
On 2016/05/23 15:40:03, Peter Beverloo wrote:
> Can we summarize the reasoning here rather than link to the bug?
> 
> I'd also like to see a TODO here to make sure that
> |notification_resources.badge| drawsNothing() on other platforms.

Done.

[Michael van Ouwerkerk, 2016-05-23 16:12:30]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-05-23 16:12:30]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2006743002/#ps20001
(title: "Tweak comment, add TODO.")

[commit-bot: I haz the power, 2016-05-23 16:12:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006743002/20001

[commit-bot: I haz the power, 2016-05-23 16:53:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 16:53:29]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Michael van Ouwerkerk, 2016-05-24 14:49:04]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-05-24 14:49:05]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2006743002/#ps40001
(title: "Fix test.")

[commit-bot: I haz the power, 2016-05-24 14:49:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006743002/40001

[commit-bot: I haz the power, 2016-05-24 17:17:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-24 17:18:55]

Description was changed from

==========
Notification badges are only supported on Android.

BUG=591394
==========

to

==========
Notification badges are only supported on Android.

BUG=591394

Committed: https://crrev.com/beb6b08839769066c793cfd63757dbb223c1a275
Cr-Commit-Position: refs/heads/master@{#395622}
==========

[commit-bot: I haz the power, 2016-05-24 17:18:56]

Patchset 3 (id:??) landed as
https://crrev.com/beb6b08839769066c793cfd63757dbb223c1a275
Cr-Commit-Position: refs/heads/master@{#395622}