Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2006733007:
network_time_tracker: Add missing gyp dependencies (Closed)
|
Created:
4 years, 7 months ago by rogerj Modified:
4 years, 6 months ago Reviewers:
Nicolas Zea CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionnetwork_time_tracker: Add missing gyp dependencies
Fixup for https://codereview.chromium.org/1835823002.
That CL only added the required dependencies to BUILD.gn. This CL adds
the dependencies to the gyp target as well.
BUG=589700
Committed: https://crrev.com/700c7f090ba6479679dd5be9c881842ffa8e4083
Cr-Commit-Position: refs/heads/master@{#396420}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
The CQ bit was checked by rogerj@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006733007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006733007/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== network_time_tracker: Add missing gyp dependencies Fixup for https://codereview.chromium.org/1835823002. That CL only added the required dependencies to BUILD.gn. This CL adds the dependencies to the gyp target as well. BUG=589700 ========== to ========== network_time_tracker: Add missing gyp dependencies Fixup for https://codereview.chromium.org/1835823002. That CL only added the required dependencies to BUILD.gn. This CL adds the dependencies to the gyp target as well. BUG=589700 ==========
rogerj@opera.com changed reviewers: + zea@chromium.org
LGTM Thanks!
The CQ bit was checked by rogerj@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006733007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006733007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/05/26 21:45:09, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) I don't see anything in the failures that I can track to this simple change, I'll retry the commit.
The CQ bit was checked by rogerj@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006733007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006733007/1
Message was sent while issue was closed.
Description was changed from ========== network_time_tracker: Add missing gyp dependencies Fixup for https://codereview.chromium.org/1835823002. That CL only added the required dependencies to BUILD.gn. This CL adds the dependencies to the gyp target as well. BUG=589700 ========== to ========== network_time_tracker: Add missing gyp dependencies Fixup for https://codereview.chromium.org/1835823002. That CL only added the required dependencies to BUILD.gn. This CL adds the dependencies to the gyp target as well. BUG=589700 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== network_time_tracker: Add missing gyp dependencies Fixup for https://codereview.chromium.org/1835823002. That CL only added the required dependencies to BUILD.gn. This CL adds the dependencies to the gyp target as well. BUG=589700 ========== to ========== network_time_tracker: Add missing gyp dependencies Fixup for https://codereview.chromium.org/1835823002. That CL only added the required dependencies to BUILD.gn. This CL adds the dependencies to the gyp target as well. BUG=589700 Committed: https://crrev.com/700c7f090ba6479679dd5be9c881842ffa8e4083 Cr-Commit-Position: refs/heads/master@{#396420} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/700c7f090ba6479679dd5be9c881842ffa8e4083 Cr-Commit-Position: refs/heads/master@{#396420} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
