Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2006733006: Implement DISALLOW_COPY_AND_ASSIGN using =delete for Linux only. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement DISALLOW_COPY_AND_ASSIGN using =delete for Linux only. This lands the new implementation for only (non-CrOS) Linux. Hopefully this will prevent regressions in cross-platform code while other platforms are brought up. BUG=447156 TEST=none Committed: https://crrev.com/999f15f7188de47ff03c8c7d00d5955a9d0a7877 Cr-Commit-Position: refs/heads/master@{#396295}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Compile fixes, narrow macro even more #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M base/macros.h View 1 2 chunks +13 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
Peter Kasting
Does this do what you were suggesting?
4 years, 7 months ago (2016-05-25 23:08:49 UTC) #2
Nico
Right. lgtm with green bots. https://codereview.chromium.org/2006733006/diff/1/base/macros.h File base/macros.h (right): https://codereview.chromium.org/2006733006/diff/1/base/macros.h#newcode30 base/macros.h:30: #if defined(OS_LINUX) && !defined(OS_CHROMEOS) ...
4 years, 7 months ago (2016-05-26 00:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006733006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006733006/80001
4 years, 6 months ago (2016-05-26 21:56:35 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-05-26 22:03:47 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 22:05:04 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/999f15f7188de47ff03c8c7d00d5955a9d0a7877
Cr-Commit-Position: refs/heads/master@{#396295}

Powered by Google App Engine
This is Rietveld 408576698