Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2006733004: Make %ThrowTypeError% function(s) strict (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make %ThrowTypeError% function(s) strict Bootstrapper previously created %ThrowTypeError% before the strict function maps existed, so making that function strict required a small amount of code reordering. This fixes a few test262 tests, but we're still non-compliant due to the fact that we have two functions instead of one (see issue 4034). BUG=v8:4925 LOG=y Committed: https://crrev.com/d84dbc7125b400dc1d01e2fffb9481bd1cb3268d Cr-Commit-Position: refs/heads/master@{#36526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M src/bootstrapper.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
adamk
Choosing Yang as a bootstrapper reviewer in case I'm missing something subtle and/or ancient about ...
4 years, 7 months ago (2016-05-24 20:00:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006733004/1
4 years, 7 months ago (2016-05-24 20:01:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 20:32:47 UTC) #6
Yang
lgtm
4 years, 7 months ago (2016-05-25 08:44:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006733004/1
4 years, 7 months ago (2016-05-25 16:58:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 17:00:36 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 17:03:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d84dbc7125b400dc1d01e2fffb9481bd1cb3268d
Cr-Commit-Position: refs/heads/master@{#36526}

Powered by Google App Engine
This is Rietveld 408576698