Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2006703004: Merge code which extracts assets from APK to file (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
michaelbai, Yaron, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge code which extracts assets from APK to file BUG=609122 Committed: https://crrev.com/6efc98a62239ae265d3a643a8e5fffa4ee30358a Cr-Commit-Position: refs/heads/master@{#396620}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 31 (16 generated)
pkotwicz
Yaron, can you please take a look?
4 years, 7 months ago (2016-05-24 20:54:54 UTC) #2
Yaron
https://codereview.chromium.org/2006703004/diff/1/base/android/java/src/org/chromium/base/FileUtils.java File base/android/java/src/org/chromium/base/FileUtils.java (right): https://codereview.chromium.org/2006703004/diff/1/base/android/java/src/org/chromium/base/FileUtils.java#newcode46 base/android/java/src/org/chromium/base/FileUtils.java:46: try (InputStream inputStream = context.getAssets().open(assetName); unfortunately we can't use ...
4 years, 7 months ago (2016-05-24 21:36:27 UTC) #3
pkotwicz
Yaron, can you please take another look? I am not using try-with-resources anymore
4 years, 7 months ago (2016-05-25 15:38:27 UTC) #4
Yaron
lgtm
4 years, 7 months ago (2016-05-25 18:39:29 UTC) #5
pkotwicz
michaelbai@ for android_webview/ mef@ for components/cronet
4 years, 7 months ago (2016-05-25 19:43:41 UTC) #7
michaelbai
android_webview LGTM
4 years, 7 months ago (2016-05-25 20:00:57 UTC) #8
pkotwicz
mef@ Ping!
4 years, 7 months ago (2016-05-26 23:10:21 UTC) #9
mef
cronet/ lgtm
4 years, 7 months ago (2016-05-27 00:44:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006703004/20001
4 years, 6 months ago (2016-05-27 15:21:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/191173)
4 years, 6 months ago (2016-05-27 15:28:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006703004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006703004/60001
4 years, 6 months ago (2016-05-27 18:54:40 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78119)
4 years, 6 months ago (2016-05-27 21:28:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006703004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006703004/60001
4 years, 6 months ago (2016-05-28 00:27:55 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-05-28 01:33:29 UTC) #29
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 01:37:18 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6efc98a62239ae265d3a643a8e5fffa4ee30358a
Cr-Commit-Position: refs/heads/master@{#396620}

Powered by Google App Engine
This is Rietveld 408576698