Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 20067003: More Math.abs tweaks for Intel platforms. (Closed)

Created:
7 years, 5 months ago by Sven Panne
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

More Math.abs tweaks for Intel platforms. Made ia32/x64 code more uniform. Minor jump tweaks. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15857

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -26 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 1 2 chunks +4 lines, -12 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 5 months ago (2013-07-24 09:54:51 UTC) #1
Michael Starzinger
LGTM.
7 years, 5 months ago (2013-07-24 12:14:42 UTC) #2
Sven Panne
7 years, 5 months ago (2013-07-24 12:17:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15857 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698