Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: src/uri.h

Issue 2006673002: Reduce boilerplace for common pattern to return MaybeHandle. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase and fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-uri.cc ('k') | src/uri.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/uri.h
diff --git a/src/uri.h b/src/uri.h
index e41e8a29e18635403f008bc1fe823a9b1164fc73..1a0a61fbc2631c3cb2674e1a66a881d91ed83e61 100644
--- a/src/uri.h
+++ b/src/uri.h
@@ -13,12 +13,12 @@ namespace internal {
class Uri : public AllStatic {
public:
- static Object* EncodeUri(Isolate* isolate, Handle<String> uri) {
+ static MaybeHandle<String> EncodeUri(Isolate* isolate, Handle<String> uri) {
return Encode(isolate, uri, true);
}
- static Object* EncodeUriComponent(Isolate* isolate,
- Handle<String> component) {
+ static MaybeHandle<String> EncodeUriComponent(Isolate* isolate,
+ Handle<String> component) {
return Encode(isolate, component, false);
}
@@ -28,7 +28,8 @@ class Uri : public AllStatic {
// unescape
private:
- static Object* Encode(Isolate* isolate, Handle<String> uri, bool is_uri);
+ static MaybeHandle<String> Encode(Isolate* isolate, Handle<String> uri,
+ bool is_uri);
// decode
};
« no previous file with comments | « src/runtime/runtime-uri.cc ('k') | src/uri.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698