src/runtime/runtime-symbol.cc - Issue 2006673002: Reduce boilerplace for common pattern to return MaybeHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-symbol.cc

Issue 2006673002: Reduce boilerplace for common pattern to return MaybeHandle. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase and fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-symbol.cc

diff --git a/src/runtime/runtime-symbol.cc b/src/runtime/runtime-symbol.cc

index 234b45606d8332c4a0bfc4ad41c4843205ad6377..f89ab34044ec517d256fa48e7b7259ca324e7295 100644

--- a/src/runtime/runtime-symbol.cc

+++ b/src/runtime/runtime-symbol.cc

@@ -52,9 +52,7 @@ RUNTIME_FUNCTION(Runtime_SymbolDescriptiveString) {

builder.AppendString(handle(String::cast(symbol->name()), isolate));

}

builder.AppendCharacter(')');

- Handle<String> result;

- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, builder.Finish());

- return *result;

+ RETURN_RESULT_OR_FAILURE(isolate, builder.Finish());

}

« no previous file with comments | « src/runtime/runtime-strings.cc ('k') | src/runtime/runtime-uri.cc » ('j') | no next file with comments »