src/pathops/SkPathOpsCubic.cpp - Issue 2006653006: pin before calling acos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkPathOpsCubic.cpp

Issue 2006653006: pin before calling acos (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkPathOpsCubic.cpp

diff --git a/src/pathops/SkPathOpsCubic.cpp b/src/pathops/SkPathOpsCubic.cpp

index 6b74fb00efac83990703727eb207997f3460c467..6c088b3edae462cb00a5625542e42e79bae9d9c0 100644

--- a/src/pathops/SkPathOpsCubic.cpp

+++ b/src/pathops/SkPathOpsCubic.cpp

@@ -419,7 +419,7 @@ int SkDCubic::RootsReal(double A, double B, double C, double D, double s[3]) {

double r;

double* roots = s;

if (R2MinusQ3 < 0) { // we have 3 real roots

- double theta = acos(R / sqrt(Q3));

+ double theta = acos(SkTPin(R / sqrt(Q3), -1., 1.)); // bug.skia.org/5222

double neg2RootQ = -2 * sqrt(Q);

r = neg2RootQ * cos(theta / 3) - adiv3;

« src/core/SkGeometry.cpp ('K') | « src/core/SkGeometry.cpp ('k') | no next file » | no next file with comments »