Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006653003: [generators] Fix loading of FormalParameterCount on 64bit archs. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Fix loading of FormalParameterCount on 64bit archs. BUG=v8:4907 Committed: https://crrev.com/ccb24b8488368538457dce78d7d0d8a4b50cf3db Cr-Commit-Position: refs/heads/master@{#36467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006653003/1
4 years, 7 months ago (2016-05-24 09:56:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 10:27:42 UTC) #4
neis
ptal
4 years, 7 months ago (2016-05-24 10:58:17 UTC) #7
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-24 11:01:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006653003/1
4 years, 7 months ago (2016-05-24 11:01:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 11:03:51 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 11:04:36 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ccb24b8488368538457dce78d7d0d8a4b50cf3db
Cr-Commit-Position: refs/heads/master@{#36467}

Powered by Google App Engine
This is Rietveld 408576698