Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2006633002: Rewrote :empty tests to avoid list-item bug. (Closed)

Created:
4 years, 7 months ago by rune
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrote :empty tests to avoid list-item bug. Run :empty tests as js-tests instead of layout tree dumps. The issue causing the original test to be flaky is reported as crbug.com/613957. R=bugsnash@chromium.org BUG=610180 Committed: https://crrev.com/00bc83a8ed9ee64cd4b478cf760fa58809b95984 Cr-Commit-Position: refs/heads/master@{#395582}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Better selectors in test #

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006633002/1
4 years, 7 months ago (2016-05-23 09:58:31 UTC) #2
rune
ptal
4 years, 7 months ago (2016-05-23 09:58:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233714)
4 years, 7 months ago (2016-05-23 12:26:31 UTC) #5
rune
4 years, 7 months ago (2016-05-24 09:53:25 UTC) #7
mstensho (USE GERRIT)
lgtm with nit (fine to ignore, though) https://codereview.chromium.org/2006633002/diff/1/third_party/WebKit/LayoutTests/fast/css/empty-pseudo-class.html File third_party/WebKit/LayoutTests/fast/css/empty-pseudo-class.html (right): https://codereview.chromium.org/2006633002/diff/1/third_party/WebKit/LayoutTests/fast/css/empty-pseudo-class.html#newcode4 third_party/WebKit/LayoutTests/fast/css/empty-pseudo-class.html:4: .empty:empty, .not-empty ...
4 years, 7 months ago (2016-05-24 10:37:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006633002/20001
4 years, 7 months ago (2016-05-24 11:06:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 13:03:02 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 13:04:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00bc83a8ed9ee64cd4b478cf760fa58809b95984
Cr-Commit-Position: refs/heads/master@{#395582}

Powered by Google App Engine
This is Rietveld 408576698