Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: content/shell/renderer/test_runner/WebFrameTestProxy.h

Issue 200663002: Add 'waitUntilExternalURLLoad' method to TestRunner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/WebFrameTestProxy.h
diff --git a/content/shell/renderer/test_runner/WebFrameTestProxy.h b/content/shell/renderer/test_runner/WebFrameTestProxy.h
index 238712bc27893d17755fd6e227b68eb22f948c1f..286e2b8e2519852a1c4aa8f905c688bf990e6b63 100644
--- a/content/shell/renderer/test_runner/WebFrameTestProxy.h
+++ b/content/shell/renderer/test_runner/WebFrameTestProxy.h
@@ -49,6 +49,11 @@ public:
const CR_DEFINE_STATIC_LOCAL(WebString, suffix, ("-can-create-without-renderer"));
return mimeType.utf8().find(suffix.utf8()) != std::string::npos;
}
+ virtual void loadURLExternally(blink::WebFrame* frame, const blink::WebURLRequest& request, blink::WebNavigationPolicy policy, const blink::WebString& suggested_name)
dmazzoni 2014/03/14 21:03:35 Could you add OVERRIDE to all of the functions tha
asanka 2014/03/14 21:45:32 Done.
+ {
+ m_baseProxy->loadURLExternally(frame, request, policy, suggested_name);
+ Base::loadURLExternally(frame, request, policy, suggested_name);
+ }
virtual void didStartProvisionalLoad(blink::WebFrame* frame)
{
if (m_version > 2)
« no previous file with comments | « content/shell/renderer/test_runner/TestRunner.cpp ('k') | content/shell/renderer/test_runner/WebTestProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698